| Message ID | 1715875538-21499-1-git-send-email-schakrabarti@linux.microsoft.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: mana: Fix the extra HZ in mana_hwc_send_request | expand |
> From: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com> > Sent: Thursday, May 16, 2024 9:06 AM > ... > Commit 62c1bff593b7 added an extra HZ along with msecs_to_jiffies. > This patch fixes that. > > Cc: stable@vger.kernel.org > Fixes: 62c1bff593b7 ("net: mana: Configure hwc timeout from hardware") > Signed-off-by: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com> > --- Looks good to me. Reviewed-by: Dexuan Cui <decui@microsoft.com>
On 5/16/2024 9:05 AM, Souradeep Chakrabarti wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > Commit 62c1bff593b7 added an extra HZ along with msecs_to_jiffies. > This patch fixes that. > > Cc: stable@vger.kernel.org > Fixes: 62c1bff593b7 ("net: mana: Configure hwc timeout from hardware") > Signed-off-by: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com> > --- > drivers/net/ethernet/microsoft/mana/hw_channel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM. Reviewed-by: Brett Creeley <brett.creeley@amd.com>
On Thu, May 16, 2024 at 09:05:38AM -0700, Souradeep Chakrabarti wrote: > Commit 62c1bff593b7 added an extra HZ along with msecs_to_jiffies. > This patch fixes that. > > Cc: stable@vger.kernel.org > Fixes: 62c1bff593b7 ("net: mana: Configure hwc timeout from hardware") > Signed-off-by: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq Please set the Subject line to [PATCH net] to indicate which tree this applies to. Andrew
diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c index 2729a2c5acf9..ca814fe8a775 100644 --- a/drivers/net/ethernet/microsoft/mana/hw_channel.c +++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c @@ -848,7 +848,7 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len, } if (!wait_for_completion_timeout(&ctx->comp_event, - (msecs_to_jiffies(hwc->hwc_timeout) * HZ))) { + (msecs_to_jiffies(hwc->hwc_timeout)))) { dev_err(hwc->dev, "HWC: Request timed out!\n"); err = -ETIMEDOUT; goto out;
Commit 62c1bff593b7 added an extra HZ along with msecs_to_jiffies. This patch fixes that. Cc: stable@vger.kernel.org Fixes: 62c1bff593b7 ("net: mana: Configure hwc timeout from hardware") Signed-off-by: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com> --- drivers/net/ethernet/microsoft/mana/hw_channel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)