| Message ID | 172192698293.1903337.4255690118685300353.stgit@ahduyck-xeon-server.home.arpa (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 697943657444a7d7123b47bc32019e62533f4863 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] fbnic: Change kconfig prompt from S390=n to !S390 | expand |
On Thu, Jul 25, 2024 at 10:03:54AM -0700, Alexander Duyck wrote: > From: Alexander Duyck <alexanderduyck@fb.com> > > In testing the recent kernel I found that the fbnic driver couldn't be > enabled on x86_64 builds. A bit of digging showed that the fbnic driver was > the only one to check for S390 to be n, all others had checked for !S390. > Since it is a boolean and not a tristate I am not sure it will be N. So > just update it to use the !S390 flag. > > A quick check via "make menuconfig" verified that after making this change > there was an option to select the fbnic driver. > > Signed-off-by: Alexander Duyck <alexanderduyck@fb.com> [...] This seems fine to me (and matches other drivers as you mentioned), but does it need: Fixes 0e03c643dc93 ("eth: fbnic: fix s390 build.") for it be applied to net? In either case: Reviewed-by: Joe Damato <jdamato@fastly.com>
On Thu, Jul 25, 2024 at 10:17 AM Joe Damato <jdamato@fastly.com> wrote: > > On Thu, Jul 25, 2024 at 10:03:54AM -0700, Alexander Duyck wrote: > > From: Alexander Duyck <alexanderduyck@fb.com> > > > > In testing the recent kernel I found that the fbnic driver couldn't be > > enabled on x86_64 builds. A bit of digging showed that the fbnic driver was > > the only one to check for S390 to be n, all others had checked for !S390. > > Since it is a boolean and not a tristate I am not sure it will be N. So > > just update it to use the !S390 flag. > > > > A quick check via "make menuconfig" verified that after making this change > > there was an option to select the fbnic driver. > > > > Signed-off-by: Alexander Duyck <alexanderduyck@fb.com> > > [...] > > This seems fine to me (and matches other drivers as you mentioned), > but does it need: > > Fixes 0e03c643dc93 ("eth: fbnic: fix s390 build.") > > for it be applied to net? > > In either case: > > Reviewed-by: Joe Damato <jdamato@fastly.com> I will add it and resubmit if/when the patch is dropped from the patchwork queue. It has been a while since I submitted anything to the net queue and previously I don't recall needing to bother with that unless it required backports to stable kernels which then also required Ccing stable. Thanks, - Alex
On Thu, Jul 25, 2024 at 04:03:30PM -0700, Alexander Duyck wrote: > On Thu, Jul 25, 2024 at 10:17 AM Joe Damato <jdamato@fastly.com> wrote: > > > > On Thu, Jul 25, 2024 at 10:03:54AM -0700, Alexander Duyck wrote: > > > From: Alexander Duyck <alexanderduyck@fb.com> > > > > > > In testing the recent kernel I found that the fbnic driver couldn't be > > > enabled on x86_64 builds. A bit of digging showed that the fbnic driver was > > > the only one to check for S390 to be n, all others had checked for !S390. > > > Since it is a boolean and not a tristate I am not sure it will be N. So > > > just update it to use the !S390 flag. > > > > > > A quick check via "make menuconfig" verified that after making this change > > > there was an option to select the fbnic driver. > > > > > > Signed-off-by: Alexander Duyck <alexanderduyck@fb.com> > > > > [...] > > > > This seems fine to me (and matches other drivers as you mentioned), > > but does it need: > > > > Fixes 0e03c643dc93 ("eth: fbnic: fix s390 build.") > > > > for it be applied to net? > > > > In either case: > > > > Reviewed-by: Joe Damato <jdamato@fastly.com> > > I will add it and resubmit if/when the patch is dropped from the > patchwork queue. Sure; makes sense. I honestly have no idea -- I think maybe Kconfig and docs are special cases or something? Just suggested the Fixes to be helpful :) - Joe
On Fri, 26 Jul 2024 10:47:08 -0700 Joe Damato wrote: > > I will add it and resubmit if/when the patch is dropped from the > > patchwork queue. > > Sure; makes sense. I honestly have no idea -- I think maybe Kconfig > and docs are special cases or something? Just suggested the Fixes to > be helpful :) The driver is unusable without this patch, so I'd say it's a fix and needs a Fixes tag. Since the ML traffic is low I'll just add it manually when applying.
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 25 Jul 2024 10:03:54 -0700 you wrote: > From: Alexander Duyck <alexanderduyck@fb.com> > > In testing the recent kernel I found that the fbnic driver couldn't be > enabled on x86_64 builds. A bit of digging showed that the fbnic driver was > the only one to check for S390 to be n, all others had checked for !S390. > Since it is a boolean and not a tristate I am not sure it will be N. So > just update it to use the !S390 flag. > > [...] Here is the summary with links: - [net] fbnic: Change kconfig prompt from S390=n to !S390 https://git.kernel.org/netdev/net/c/697943657444 You are awesome, thank you!
diff --git a/drivers/net/ethernet/meta/Kconfig b/drivers/net/ethernet/meta/Kconfig index 86034ea4ba5b..c002ede36402 100644 --- a/drivers/net/ethernet/meta/Kconfig +++ b/drivers/net/ethernet/meta/Kconfig @@ -20,7 +20,7 @@ if NET_VENDOR_META config FBNIC tristate "Meta Platforms Host Network Interface" depends on X86_64 || COMPILE_TEST - depends on S390=n + depends on !S390 depends on MAX_SKB_FRAGS < 22 depends on PCI_MSI select PHYLINK