| Message ID | 174240634772.1745174.5690351737682751849.stgit@ahduyck-xeon-server.home.arpa (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: phylink: Remove unused function pointer from phylink structure | expand |
> -----Original Message----- > From: Alexander Duyck <alexander.duyck@gmail.com> > Sent: Wednesday, March 19, 2025 10:46 AM > To: netdev@vger.kernel.org > Cc: linux@armlinux.org.uk; andrew@lunn.ch; hkallweit1@gmail.com; > davem@davemloft.net; kuba@kernel.org; pabeni@redhat.com > Subject: [net-next PATCH] net: phylink: Remove unused function pointer from > phylink structure > > From: Alexander Duyck <alexanderduyck@fb.com> > > From what I can tell the get_fixed_state pointer in the phylink structure > hasn't been used since commit <5c05c1dbb177> ("net: phylink, dsa: eliminate > phylink_fixed_state_cb()") . Since I can't find any users for it we might > as well just drop the pointer. > > Fixes: 5c05c1dbb177 ("net: phylink, dsa: eliminate phylink_fixed_state_cb()") > Signed-off-by: Alexander Duyck <alexanderduyck@fb.com> > --- > drivers/net/phy/phylink.c | 2 -- > 1 file changed, 2 deletions(-) > Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> > diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c > index 0f70a7f3dfcc..16a1f31f0091 100644 > --- a/drivers/net/phy/phylink.c > +++ b/drivers/net/phy/phylink.c > @@ -72,8 +72,6 @@ struct phylink { > struct gpio_desc *link_gpio; > unsigned int link_irq; > struct timer_list link_poll; > - void (*get_fixed_state)(struct net_device *dev, > - struct phylink_link_state *s); > > struct mutex state_mutex; > struct phylink_link_state phy_state; > >
On Wed, Mar 19, 2025 at 10:46:25AM -0700, Alexander Duyck wrote: > From: Alexander Duyck <alexanderduyck@fb.com> > > From what I can tell the get_fixed_state pointer in the phylink structure > hasn't been used since commit <5c05c1dbb177> ("net: phylink, dsa: eliminate > phylink_fixed_state_cb()") . Since I can't find any users for it we might > as well just drop the pointer. > > Fixes: 5c05c1dbb177 ("net: phylink, dsa: eliminate phylink_fixed_state_cb()") > Signed-off-by: Alexander Duyck <alexanderduyck@fb.com> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Thanks!
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 0f70a7f3dfcc..16a1f31f0091 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -72,8 +72,6 @@ struct phylink { struct gpio_desc *link_gpio; unsigned int link_irq; struct timer_list link_poll; - void (*get_fixed_state)(struct net_device *dev, - struct phylink_link_state *s); struct mutex state_mutex; struct phylink_link_state phy_state;