| Message ID | 195d71a41fb3e6d2fc36bc843e5909c9240ef163.1689077819.git.gnault@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8d6eba33a2726e463eeab5c42b8eb373d7462127 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: Mark the sk parameter of routing functions as 'const'. | expand |
On Tue, Jul 11, 2023 at 03:06:14PM +0200, Guillaume Nault wrote: > These functions don't need to modify the socket, so let's allow the > callers to pass a const struct sock *. > > Signed-off-by: Guillaume Nault <gnault@redhat.com> Reviewed-by: Simon Horman <simon.horman@corigine.com>
On 7/11/23 7:06 AM, Guillaume Nault wrote: > These functions don't need to modify the socket, so let's allow the > callers to pass a const struct sock *. > > Signed-off-by: Guillaume Nault <gnault@redhat.com> > --- > include/net/route.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: David Ahern <dsahern@kernel.org>
diff --git a/include/net/route.h b/include/net/route.h index 5a5c726472bd..d8d150155195 100644 --- a/include/net/route.h +++ b/include/net/route.h @@ -163,7 +163,7 @@ static inline struct rtable *ip_route_output(struct net *net, __be32 daddr, } static inline struct rtable *ip_route_output_ports(struct net *net, struct flowi4 *fl4, - struct sock *sk, + const struct sock *sk, __be32 daddr, __be32 saddr, __be16 dport, __be16 sport, __u8 proto, __u8 tos, int oif) @@ -309,7 +309,7 @@ static inline void ip_route_connect_init(struct flowi4 *fl4, __be32 dst, static inline struct rtable *ip_route_connect(struct flowi4 *fl4, __be32 dst, __be32 src, int oif, u8 protocol, __be16 sport, __be16 dport, - struct sock *sk) + const struct sock *sk) { struct net *net = sock_net(sk); struct rtable *rt; @@ -330,7 +330,7 @@ static inline struct rtable *ip_route_connect(struct flowi4 *fl4, __be32 dst, static inline struct rtable *ip_route_newports(struct flowi4 *fl4, struct rtable *rt, __be16 orig_sport, __be16 orig_dport, __be16 sport, __be16 dport, - struct sock *sk) + const struct sock *sk) { if (sport != orig_sport || dport != orig_dport) { fl4->fl4_dport = dport;
These functions don't need to modify the socket, so let's allow the callers to pass a const struct sock *. Signed-off-by: Guillaume Nault <gnault@redhat.com> --- include/net/route.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)