| Message ID | 1de8170c1b7dec795f8ca257fbd56c61c36ad5a2.1607050389.git.andreas.a.roeseler@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | add support for RFC 8335 PROBE | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 8107 this patch: 8107 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 8219 this patch: 8219 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On 12/3/20 8:16 PM, Andreas Roeseler wrote: > Section 8 of RFC 8335 specifies potential security concerns of > responding to PROBE requests, and states that nodes that support PROBE > functionality MUST be able to enable/disable responses and it is > disabled by default. > > Add sysctl to enable responses to PROBE messages. > > Signed-off-by: Andreas Roeseler <andreas.a.roeseler@gmail.com> > --- > include/net/netns/ipv4.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/net/netns/ipv4.h b/include/net/netns/ipv4.h > index 8e4fcac4df72..1d9b74228f3e 100644 > --- a/include/net/netns/ipv4.h > +++ b/include/net/netns/ipv4.h > @@ -85,6 +85,7 @@ struct netns_ipv4 { > #endif > > int sysctl_icmp_echo_ignore_all; > + int sysctl_icmp_echo_enable_probe; > int sysctl_icmp_echo_ignore_broadcasts; > int sysctl_icmp_ignore_bogus_error_responses; > int sysctl_icmp_ratelimit; > this can be folded into patch 4; no need for a standalone patch here.
diff --git a/include/net/netns/ipv4.h b/include/net/netns/ipv4.h index 8e4fcac4df72..1d9b74228f3e 100644 --- a/include/net/netns/ipv4.h +++ b/include/net/netns/ipv4.h @@ -85,6 +85,7 @@ struct netns_ipv4 { #endif int sysctl_icmp_echo_ignore_all; + int sysctl_icmp_echo_enable_probe; int sysctl_icmp_echo_ignore_broadcasts; int sysctl_icmp_ignore_bogus_error_responses; int sysctl_icmp_ratelimit;
Section 8 of RFC 8335 specifies potential security concerns of responding to PROBE requests, and states that nodes that support PROBE functionality MUST be able to enable/disable responses and it is disabled by default. Add sysctl to enable responses to PROBE messages. Signed-off-by: Andreas Roeseler <andreas.a.roeseler@gmail.com> --- include/net/netns/ipv4.h | 1 + 1 file changed, 1 insertion(+)