diff mbox series

[v2,1/1] net: dsa: seville: the packet buffer is 2 megabits, not megabytes

Message ID 20201014132743.277619-1-fido_max@inbox.ru (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series [v2,1/1] net: dsa: seville: the packet buffer is 2 megabits, not megabytes | expand

Commit Message

Maxim Kochetkov Oct. 14, 2020, 1:27 p.m. UTC
The VSC9953 Seville switch has 2 megabits of buffer split into 4360
words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabits.
2 megabits is (2048 / 8) * 1024 = 256 * 1024.

Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
Fixes: a63ed92d217f ("net: dsa: seville: fix buffer size of the queue system")
---
 drivers/net/dsa/ocelot/seville_vsc9953.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.27.0

Comments

Vladimir Oltean Oct. 14, 2020, 1:58 p.m. UTC | #1
On Wed, Oct 14, 2020 at 04:27:43PM +0300, Maxim Kochetkov wrote:
> The VSC9953 Seville switch has 2 megabits of buffer split into 4360
> words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabits.
> 2 megabits is (2048 / 8) * 1024 = 256 * 1024.
> 
> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
> Fixes: a63ed92d217f ("net: dsa: seville: fix buffer size of the queue system")
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

This should go to "net".
Jakub Kicinski Oct. 15, 2020, 4:44 p.m. UTC | #2
On Wed, 14 Oct 2020 16:27:43 +0300 Maxim Kochetkov wrote:
> The VSC9953 Seville switch has 2 megabits of buffer split into 4360
> words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabits.
> 2 megabits is (2048 / 8) * 1024 = 256 * 1024.
> 
> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
> Fixes: a63ed92d217f ("net: dsa: seville: fix buffer size of the queue system")

Maxim, did you hand-edit this patch?  It's mangled.

Please resend.
diff mbox series

Patch

diff --git a/drivers/net/dsa/ocelot/seville_vsc9953.c b/drivers/net/dsa/ocelot/seville_vsc9953.c
index 9e9fd19e1d00..e2cd49eec037 100644
--- a/drivers/net/dsa/ocelot/seville_vsc9953.c
+++ b/drivers/net/dsa/ocelot/seville_vsc9953.c
@@ -1010,7 +1010,7 @@  static const struct felix_info seville_info_vsc9953 = {
	.vcap_is2_keys		= vsc9953_vcap_is2_keys,
	.vcap_is2_actions	= vsc9953_vcap_is2_actions,
	.vcap			= vsc9953_vcap_props,
-	.shared_queue_sz	= 2048 * 1024,
+	.shared_queue_sz	= 256 * 1024,
	.num_mact_rows		= 2048,
	.num_ports		= 10,
	.mdio_bus_alloc		= vsc9953_mdio_bus_alloc,