From patchwork Mon Nov 2 11:23:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873583 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D2DFC00A89 for ; Mon, 2 Nov 2020 11:27:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 094692084C for ; Mon, 2 Nov 2020 11:26:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QfadVdOy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728998AbgKBL06 (ORCPT ); Mon, 2 Nov 2020 06:26:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728781AbgKBLY4 (ORCPT ); Mon, 2 Nov 2020 06:24:56 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BB37C061A04 for ; Mon, 2 Nov 2020 03:24:55 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id k10so12798841wrw.13 for ; Mon, 02 Nov 2020 03:24:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=phz21+N6URi4CcT/YO1+niu4iFcUjLLHLqxB18E2o5Y=; b=QfadVdOy9Fl9zbkh80hfIPvPz3gNyuDG3E8PgTyr3iJ6FgsbshhFOmkBOLkPJRM+cS EbKUFWAfKl+jS9COFsJZ8VEzm3Ljt/H3BTbFUiAEX8SpXLdLujSUmWNlOOaR996bjO5X ZpwGzWoAYJQNQF4ErEXvUD0iJGRGMHnvrO7wF6dkvOHyfE7kMjCF4zK+LHNuOkOZxpep pPxsA2NYaA/RjVWsM1+QVNNr25GTO1iv0QHGgOO31mXvatibCudIkTu4BBuclSsU5BKh oncw3u9nBbEhDE2UaEnT5Z4Da0r6mOP0590VFKMAGPFGegyvCA0O5p0uOGggx6X0A8k4 BN1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=phz21+N6URi4CcT/YO1+niu4iFcUjLLHLqxB18E2o5Y=; b=LOjjV0xWXEadIizwC7PYsn3YBnx/N5TrvBVtmHaATbu8/P9HAl5BH8yDaakMIPpH31 amJ9Q+gpzgSmv+T05w6ICdT6aeV5fLQ9zwiNWSetZJTpZswxbAQbqeIRRRs9vPbou2cX TOAELfY8yu+pyn5Ex0oQthmtxRrU1a/lIrmqia9E0Iqtjkpqo9985/nja/1cu91lwN6U rv2E6uvM0HC6fErxZeo6+gRaErHL88KS7OSZ7mtxh5hBiZFkWk5y4SJIMbQjhwhVYRFX 4SqGaaUHu20PslLTKydf8Ud19bCJf9NpipfmMCOQE0g0JD1YvCUC2Ef1MZb4zyGMAnni /1UA== X-Gm-Message-State: AOAM533tvlXhWaOMPlfOvC/7hUHn1Hf54U0pN9a4gkXO5Lyfz4AH01YY TjSFGZVwDAgY4sYWCMscwv04/A== X-Google-Smtp-Source: ABdhPJzNF5spMxVcMYFSeCHg8D9zRR3jAaylmqt+JUIJZ1DX9Vnz69yq3266Tb3tLFRcshxVfdp2yg== X-Received: by 2002:adf:9361:: with SMTP id 88mr18815974wro.37.1604316293800; Mon, 02 Nov 2020 03:24:53 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:53 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Ping-Ke Shih , "David S. Miller" , Jakub Kicinski , Larry Finger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 26/41] rtlwifi: phy: Remove set but unused variable 'bbvalue' Date: Mon, 2 Nov 2020 11:23:55 +0000 Message-Id: <20201102112410.1049272-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c: In function ‘_rtl8723e_phy_iq_calibrate’: drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c:1150:6: warning: variable ‘bbvalue’ set but not used [-Wunused-but-set-variable] Cc: Ping-Ke Shih Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Larry Finger Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c index fa0eed434d4f6..fe9b407dc2aff 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c @@ -1147,10 +1147,8 @@ static void _rtl8723e_phy_iq_calibrate(struct ieee80211_hw *hw, const u32 retrycount = 2; - u32 bbvalue; - if (t == 0) { - bbvalue = rtl_get_bbreg(hw, 0x800, MASKDWORD); + rtl_get_bbreg(hw, 0x800, MASKDWORD); rtl8723_save_adda_registers(hw, adda_reg, rtlphy->adda_backup, 16);