diff mbox series

IPv4: RTM_GETROUTE: Add RTA_ENCAP to result

Message ID 20201112081008.GA57799@tws (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series IPv4: RTM_GETROUTE: Add RTA_ENCAP to result | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Guessed tree name to be net-next
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 5 this patch: 5
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch warning CHECK: Alignment should match open parenthesis
netdev/build_allmodconfig_warn success Errors and warnings before: 5 this patch: 5
netdev/header_inline success Link
netdev/stable success Stable not CCed

Commit Message

Oliver Herms Nov. 12, 2020, 8:10 a.m. UTC
This patch adds an IPv4 routes encapsulation attribute
to the result of netlink RTM_GETROUTE requests
(e.g. ip route get 192.0.2.1).

Signed-off-by: Oliver Herms <oliver.peter.herms@gmail.com>
---
 net/ipv4/route.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Jakub Kicinski Nov. 12, 2020, 10:27 p.m. UTC | #1
On Thu, 12 Nov 2020 09:10:08 +0100 Oliver Herms wrote:
> This patch adds an IPv4 routes encapsulation attribute
> to the result of netlink RTM_GETROUTE requests
> (e.g. ip route get 192.0.2.1).
> 
> Signed-off-by: Oliver Herms <oliver.peter.herms@gmail.com>
> ---
>  net/ipv4/route.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index dc2a399cd9f4..b4d3384697cb 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -2872,6 +2872,9 @@ static int rt_fill_info(struct net *net, __be32 dst, __be32 src,
>  	if (rt->dst.dev &&
>  	    nla_put_u32(skb, RTA_OIF, rt->dst.dev->ifindex))
>  		goto nla_put_failure;
> +	if (rt->dst.lwtstate && lwtunnel_fill_encap(skb, rt->dst.lwtstate,
> +		RTA_ENCAP, RTA_ENCAP_TYPE) < 0)
> +		goto nla_put_failure;

Please fix this checkpatch warning:

CHECK: Alignment should match open parenthesis
#25: FILE: net/ipv4/route.c:2876:
+	if (rt->dst.lwtstate && lwtunnel_fill_encap(skb, rt->dst.lwtstate,
+		RTA_ENCAP, RTA_ENCAP_TYPE) < 0)
diff mbox series

Patch

diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index dc2a399cd9f4..b4d3384697cb 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -2872,6 +2872,9 @@  static int rt_fill_info(struct net *net, __be32 dst, __be32 src,
 	if (rt->dst.dev &&
 	    nla_put_u32(skb, RTA_OIF, rt->dst.dev->ifindex))
 		goto nla_put_failure;
+	if (rt->dst.lwtstate && lwtunnel_fill_encap(skb, rt->dst.lwtstate,
+		RTA_ENCAP, RTA_ENCAP_TYPE) < 0)
+		goto nla_put_failure;
 #ifdef CONFIG_IP_ROUTE_CLASSID
 	if (rt->dst.tclassid &&
 	    nla_put_u32(skb, RTA_FLOW, rt->dst.tclassid))