| Message ID | 20201113050919epcms2p7487583bf846376040a9874a7eb39fdae@epcms2p7 (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/2] nfc: s3fwrn82: Add driver for Samsung S3FWRN82 NFC Chip | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | WARNING: DT bindings should be in DT schema format. See: Documentation/devicetree/writing-schema.rst WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Fri, 13 Nov 2020 at 06:09, Bongsu Jeon <bongsu.jeon@samsung.com> wrote: > > > Add the device tree bindings for Samsung S3FWRN82 NFC controller. > S3FWRN82 is using NCI protocol and I2C communication interface. > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> > --- > .../devicetree/bindings/net/nfc/s3fwrn82.txt | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn82.txt > > diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn82.txt b/Documentation/devicetree/bindings/net/nfc/s3fwrn82.txt > new file mode 100644 > index 000000000000..03ed880e1c7f > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/nfc/s3fwrn82.txt > @@ -0,0 +1,30 @@ > +* Samsung S3FWRN82 NCI NFC Controller > + > +Required properties: > +- compatible: Should be "samsung,s3fwrn82-i2c". > +- reg: address on the bus > +- interrupts: GPIO interrupt to which the chip is connected > +- en-gpios: Output GPIO pin used for enabling/disabling the chip > +- wake-gpios: Output GPIO pin used to enter firmware mode and > + sleep/wakeup control > + The bindings should be the first file in the series. However it does not really matter as this patch should be part of the existing s3fwrn5 driver. When submitting bindings, please use the title to match the bindings and use YAML format. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn82.txt b/Documentation/devicetree/bindings/net/nfc/s3fwrn82.txt new file mode 100644 index 000000000000..03ed880e1c7f --- /dev/null +++ b/Documentation/devicetree/bindings/net/nfc/s3fwrn82.txt @@ -0,0 +1,30 @@ +* Samsung S3FWRN82 NCI NFC Controller + +Required properties: +- compatible: Should be "samsung,s3fwrn82-i2c". +- reg: address on the bus +- interrupts: GPIO interrupt to which the chip is connected +- en-gpios: Output GPIO pin used for enabling/disabling the chip +- wake-gpios: Output GPIO pin used to enter firmware mode and + sleep/wakeup control + +Example: + + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + + i2c4 { + #address-cells = <1>; + #size-cells = <0>; + + s3fwrn82@27 { + compatible = "samsung,s3fwrn82-i2c"; + reg = <0x27>; + + interrupt-parent = <&gpa1>; + interrupts = <3 IRQ_TYPE_LEVEL_HIGH>; + + en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>; + wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>; + }; + };
Add the device tree bindings for Samsung S3FWRN82 NFC controller. S3FWRN82 is using NCI protocol and I2C communication interface. Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> --- .../devicetree/bindings/net/nfc/s3fwrn82.txt | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn82.txt --