diff mbox series

[net-next,v3,1/4] ethtool: add ETHTOOL_COALESCE_ALL_PARAMS define

Message ID 20201113231655.139948-1-acardace@redhat.com (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series [net-next,v3,1/4] ethtool: add ETHTOOL_COALESCE_ALL_PARAMS define | expand

Commit Message

Antonio Cardace Nov. 13, 2020, 11:16 p.m. UTC
This bitmask represents all existing coalesce parameters.

Signed-off-by: Antonio Cardace <acardace@redhat.com>
---
 include/linux/ethtool.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Michal Kubecek Nov. 16, 2020, 4:02 p.m. UTC | #1
On Sat, Nov 14, 2020 at 12:16:52AM +0100, Antonio Cardace wrote:
> This bitmask represents all existing coalesce parameters.
> 
> Signed-off-by: Antonio Cardace <acardace@redhat.com>

Reviewed-by: Michal Kubecek <mkubecek@suse.cz>

> ---
>  include/linux/ethtool.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
> index 6408b446051f..e3da25b51ae4 100644
> --- a/include/linux/ethtool.h
> +++ b/include/linux/ethtool.h
> @@ -215,6 +215,7 @@ bool ethtool_convert_link_mode_to_legacy_u32(u32 *legacy_u32,
>  #define ETHTOOL_COALESCE_TX_USECS_HIGH		BIT(19)
>  #define ETHTOOL_COALESCE_TX_MAX_FRAMES_HIGH	BIT(20)
>  #define ETHTOOL_COALESCE_RATE_SAMPLE_INTERVAL	BIT(21)
> +#define ETHTOOL_COALESCE_ALL_PARAMS		GENMASK(21, 0)
>  
>  #define ETHTOOL_COALESCE_USECS						\
>  	(ETHTOOL_COALESCE_RX_USECS | ETHTOOL_COALESCE_TX_USECS)
> -- 
> 2.28.0
>
Jakub Kicinski Nov. 17, 2020, 12:48 a.m. UTC | #2
Please add a cover letter to this series.

Preferably with the output of the test passing :)
diff mbox series

Patch

diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index 6408b446051f..e3da25b51ae4 100644
--- a/include/linux/ethtool.h
+++ b/include/linux/ethtool.h
@@ -215,6 +215,7 @@  bool ethtool_convert_link_mode_to_legacy_u32(u32 *legacy_u32,
 #define ETHTOOL_COALESCE_TX_USECS_HIGH		BIT(19)
 #define ETHTOOL_COALESCE_TX_MAX_FRAMES_HIGH	BIT(20)
 #define ETHTOOL_COALESCE_RATE_SAMPLE_INTERVAL	BIT(21)
+#define ETHTOOL_COALESCE_ALL_PARAMS		GENMASK(21, 0)
 
 #define ETHTOOL_COALESCE_USECS						\
 	(ETHTOOL_COALESCE_RX_USECS | ETHTOOL_COALESCE_TX_USECS)