| Message ID | 20201127193727.2875003-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: flow_offload: remove trailing semicolon in macro definition | expand |
On 27/11/2020 19:37, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > net/core/flow_offload.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c > index d4474c812b64..59ddfd3f3876 100644 > --- a/net/core/flow_offload.c > +++ b/net/core/flow_offload.c > @@ -32,7 +32,7 @@ EXPORT_SYMBOL(flow_rule_alloc); > struct flow_dissector *__d = (__m)->dissector; \ > \ > (__out)->key = skb_flow_dissector_target(__d, __type, (__m)->key); \ > - (__out)->mask = skb_flow_dissector_target(__d, __type, (__m)->mask); \ > + (__out)->mask = skb_flow_dissector_target(__d, __type, (__m)->mask) \ > Strictly speaking shouldn't this macro have a do {} while (0) around it anyway? -ed
diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c index d4474c812b64..59ddfd3f3876 100644 --- a/net/core/flow_offload.c +++ b/net/core/flow_offload.c @@ -32,7 +32,7 @@ EXPORT_SYMBOL(flow_rule_alloc); struct flow_dissector *__d = (__m)->dissector; \ \ (__out)->key = skb_flow_dissector_target(__d, __type, (__m)->key); \ - (__out)->mask = skb_flow_dissector_target(__d, __type, (__m)->mask); \ + (__out)->mask = skb_flow_dissector_target(__d, __type, (__m)->mask) \ void flow_rule_match_meta(const struct flow_rule *rule, struct flow_match_meta *out)