| Message ID | 20201130002135.6537-4-stephen@networkplumber.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2319db905295fa47c651b52ae09a8d7bf305c6f7 |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | Fix compiler warnings from GCC-10 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Stephen Hemminger <stephen@networkplumber.org> writes: > Gcc-10 complains about referencing a zero size array. > This occurs because the array of keys is actually in the following > structure which is part of the overall selector. > > The original code was safe, but better to just use the key > array directly. > > Fixes: 2d9a8dc439ee ("tc: p_ip6: Support pedit of IPv6 dsfield") > Cc: petrm@mellanox.com > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Reviewed-by: Petr Machata <petrm@nvidia.com>
diff --git a/tc/p_ip6.c b/tc/p_ip6.c index 71660c610c82..83a6ae8183a7 100644 --- a/tc/p_ip6.c +++ b/tc/p_ip6.c @@ -82,7 +82,7 @@ parse_ip6(int *argc_p, char ***argv_p, /* Shift the field by 4 bits on success. */ if (!res) { int nkeys = sel->sel.nkeys; - struct tc_pedit_key *key = &sel->sel.keys[nkeys - 1]; + struct tc_pedit_key *key = &sel->keys[nkeys - 1]; key->mask = htonl(ntohl(key->mask) << 4 | 0xf); key->val = htonl(ntohl(key->val) << 4);
Gcc-10 complains about referencing a zero size array. This occurs because the array of keys is actually in the following structure which is part of the overall selector. The original code was safe, but better to just use the key array directly. Fixes: 2d9a8dc439ee ("tc: p_ip6: Support pedit of IPv6 dsfield") Cc: petrm@mellanox.com Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- tc/p_ip6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)