| Message ID | 20201202124515.24110-1-info@metux.net (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: 8021q: use netdev_info() instead of pr_info() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | CHECK: Alignment should match open parenthesis WARNING: From:/Signed-off-by: email name mismatch: 'From: "Enrico Weigelt, metux IT consult" <info@metux.net>' != 'Signed-off-by: Enrico Weigelt <info@metux.net>' |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On 02.12.20 14:45, Enrico Weigelt, metux IT consult wrote: > Use netdev_info() instead of pr_info() for more consistent log output. > > Signed-off-by: Enrico Weigelt <info@metux.net> > --- > net/8021q/vlan.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c > index f292e0267bb9..d3a6f4ffdaef 100644 > --- a/net/8021q/vlan.c > +++ b/net/8021q/vlan.c > @@ -132,7 +132,7 @@ int vlan_check_real_dev(struct net_device *real_dev, > const char *name = real_dev->name; > > if (real_dev->features & NETIF_F_VLAN_CHALLENGED) { > - pr_info("VLANs not supported on %s\n", name); > + netdev_info(real_dev, "VLANs not supported on %s\n", name); Could you please also remove the real_dev->name string here? netdev_info() should insert it automatically. Same below. > NL_SET_ERR_MSG_MOD(extack, "VLANs not supported on device"); > return -EOPNOTSUPP; > } > @@ -385,7 +385,7 @@ static int vlan_device_event(struct notifier_block *unused, unsigned long event, > > if ((event == NETDEV_UP) && > (dev->features & NETIF_F_HW_VLAN_CTAG_FILTER)) { > - pr_info("adding VLAN 0 to HW filter on device %s\n", > + netdev_info(dev, "adding VLAN 0 to HW filter on device %s\n", > dev->name); > vlan_vid_add(dev, htons(ETH_P_8021Q), 0); > } >
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index f292e0267bb9..d3a6f4ffdaef 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -132,7 +132,7 @@ int vlan_check_real_dev(struct net_device *real_dev, const char *name = real_dev->name; if (real_dev->features & NETIF_F_VLAN_CHALLENGED) { - pr_info("VLANs not supported on %s\n", name); + netdev_info(real_dev, "VLANs not supported on %s\n", name); NL_SET_ERR_MSG_MOD(extack, "VLANs not supported on device"); return -EOPNOTSUPP; } @@ -385,7 +385,7 @@ static int vlan_device_event(struct notifier_block *unused, unsigned long event, if ((event == NETDEV_UP) && (dev->features & NETIF_F_HW_VLAN_CTAG_FILTER)) { - pr_info("adding VLAN 0 to HW filter on device %s\n", + netdev_info(dev, "adding VLAN 0 to HW filter on device %s\n", dev->name); vlan_vid_add(dev, htons(ETH_P_8021Q), 0); }
Use netdev_info() instead of pr_info() for more consistent log output. Signed-off-by: Enrico Weigelt <info@metux.net> --- net/8021q/vlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)