| Message ID | 20201203102234.648540-1-jackmanb@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] tools/resolve_btfids: Fix some error messages | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/subject_prefix | success | Link |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | CHECK: Alignment should match open parenthesis |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Thu, Dec 03, 2020 at 10:22:34AM +0000, Brendan Jackman wrote: > Add missing newlines and fix polarity of strerror argument. > > Signed-off-by: Brendan Jackman <jackmanb@google.com> Acked-by: Jiri Olsa <jolsa@redhat.com> thanks, jirka > --- > tools/bpf/resolve_btfids/main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c > index dfa540d8a02d..e3ea569ee125 100644 > --- a/tools/bpf/resolve_btfids/main.c > +++ b/tools/bpf/resolve_btfids/main.c > @@ -454,7 +454,7 @@ static int symbols_collect(struct object *obj) > return -ENOMEM; > > if (id->addr_cnt >= ADDR_CNT) { > - pr_err("FAILED symbol %s crossed the number of allowed lists", > + pr_err("FAILED symbol %s crossed the number of allowed lists\n", > id->name); > return -1; > } > @@ -477,8 +477,8 @@ static int symbols_resolve(struct object *obj) > btf = btf__parse(obj->btf ?: obj->path, NULL); > err = libbpf_get_error(btf); > if (err) { > - pr_err("FAILED: load BTF from %s: %s", > - obj->path, strerror(err)); > + pr_err("FAILED: load BTF from %s: %s\n", > + obj->path, strerror(-err)); > return -1; > } > > > base-commit: 97306be45fbe7a02461c3c2a57e666cf662b1aaf > -- > 2.29.2.454.gaff20da3a2-goog >
On Thu, Dec 03, 2020 at 10:22:34AM +0000, Brendan Jackman wrote: > Add missing newlines and fix polarity of strerror argument. > > Signed-off-by: Brendan Jackman <jackmanb@google.com> Applied, Thanks
diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c index dfa540d8a02d..e3ea569ee125 100644 --- a/tools/bpf/resolve_btfids/main.c +++ b/tools/bpf/resolve_btfids/main.c @@ -454,7 +454,7 @@ static int symbols_collect(struct object *obj) return -ENOMEM; if (id->addr_cnt >= ADDR_CNT) { - pr_err("FAILED symbol %s crossed the number of allowed lists", + pr_err("FAILED symbol %s crossed the number of allowed lists\n", id->name); return -1; } @@ -477,8 +477,8 @@ static int symbols_resolve(struct object *obj) btf = btf__parse(obj->btf ?: obj->path, NULL); err = libbpf_get_error(btf); if (err) { - pr_err("FAILED: load BTF from %s: %s", - obj->path, strerror(err)); + pr_err("FAILED: load BTF from %s: %s\n", + obj->path, strerror(-err)); return -1; }
Add missing newlines and fix polarity of strerror argument. Signed-off-by: Brendan Jackman <jackmanb@google.com> --- tools/bpf/resolve_btfids/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) base-commit: 97306be45fbe7a02461c3c2a57e666cf662b1aaf