diff mbox series

net: 8021q: vlan: reduce noise in driver initialization

Message ID 20201208084912.20949-1-info@metux.net (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series net: 8021q: vlan: reduce noise in driver initialization | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Guessed tree name to be net-next
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit fail Errors and warnings before: 0 this patch: 5
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 17 lines checked
netdev/build_allmodconfig_warn fail Errors and warnings before: 0 this patch: 5
netdev/header_inline success Link
netdev/stable success Stable not CCed

Commit Message

Enrico Weigelt, metux IT consult Dec. 8, 2020, 8:49 a.m. UTC
If drivers work properly, they should be silent. Thus remove the
unncessary noise von initialization.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
 net/8021q/vlan.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

kernel test robot Dec. 8, 2020, 12:50 p.m. UTC | #1
Hi "Enrico,

I love your patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on net-next/master net/master linus/master v5.10-rc7 next-20201207]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Enrico-Weigelt-metux-IT-consult/net-8021q-vlan-reduce-noise-in-driver-initialization/20201208-165821
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 09162bc32c880a791c6c0668ce0745cf7958f576
config: i386-randconfig-s001-20201208 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-179-ga00755aa-dirty
        # https://github.com/0day-ci/linux/commit/7c73ca17c3872132d7bd1b9407a26dd5ed916e2c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Enrico-Weigelt-metux-IT-consult/net-8021q-vlan-reduce-noise-in-driver-initialization/20201208-165821
        git checkout 7c73ca17c3872132d7bd1b9407a26dd5ed916e2c
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: net/8021q/vlan_dev.o: in function `strlcpy':
>> include/linux/string.h:346: undefined reference to `vlan_fullname'
>> ld: include/linux/string.h:346: undefined reference to `vlan_version'

vim +346 include/linux/string.h

6974f0c4555e28 Daniel Micay  2017-07-12  337  
6974f0c4555e28 Daniel Micay  2017-07-12  338  /* defined after fortified strlen to reuse it */
6974f0c4555e28 Daniel Micay  2017-07-12  339  extern size_t __real_strlcpy(char *, const char *, size_t) __RENAME(strlcpy);
6974f0c4555e28 Daniel Micay  2017-07-12  340  __FORTIFY_INLINE size_t strlcpy(char *p, const char *q, size_t size)
6974f0c4555e28 Daniel Micay  2017-07-12  341  {
6974f0c4555e28 Daniel Micay  2017-07-12  342  	size_t ret;
6974f0c4555e28 Daniel Micay  2017-07-12  343  	size_t p_size = __builtin_object_size(p, 0);
6974f0c4555e28 Daniel Micay  2017-07-12  344  	size_t q_size = __builtin_object_size(q, 0);
6974f0c4555e28 Daniel Micay  2017-07-12  345  	if (p_size == (size_t)-1 && q_size == (size_t)-1)
6974f0c4555e28 Daniel Micay  2017-07-12 @346  		return __real_strlcpy(p, q, size);
6974f0c4555e28 Daniel Micay  2017-07-12  347  	ret = strlen(q);
6974f0c4555e28 Daniel Micay  2017-07-12  348  	if (size) {
6974f0c4555e28 Daniel Micay  2017-07-12  349  		size_t len = (ret >= size) ? size - 1 : ret;
6974f0c4555e28 Daniel Micay  2017-07-12  350  		if (__builtin_constant_p(len) && len >= p_size)
6974f0c4555e28 Daniel Micay  2017-07-12  351  			__write_overflow();
6974f0c4555e28 Daniel Micay  2017-07-12  352  		if (len >= p_size)
6974f0c4555e28 Daniel Micay  2017-07-12  353  			fortify_panic(__func__);
47227d27e2fcb0 Daniel Axtens 2020-06-03  354  		__underlying_memcpy(p, q, len);
6974f0c4555e28 Daniel Micay  2017-07-12  355  		p[len] = '\0';
6974f0c4555e28 Daniel Micay  2017-07-12  356  	}
6974f0c4555e28 Daniel Micay  2017-07-12  357  	return ret;
6974f0c4555e28 Daniel Micay  2017-07-12  358  }
6974f0c4555e28 Daniel Micay  2017-07-12  359  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
kernel test robot Dec. 8, 2020, 4:41 p.m. UTC | #2
Hi "Enrico,

I love your patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on net-next/master net/master linus/master v5.10-rc7 next-20201208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Enrico-Weigelt-metux-IT-consult/net-8021q-vlan-reduce-noise-in-driver-initialization/20201208-165821
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 09162bc32c880a791c6c0668ce0745cf7958f576
config: nds32-randconfig-r014-20201208 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/7c73ca17c3872132d7bd1b9407a26dd5ed916e2c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Enrico-Weigelt-metux-IT-consult/net-8021q-vlan-reduce-noise-in-driver-initialization/20201208-165821
        git checkout 7c73ca17c3872132d7bd1b9407a26dd5ed916e2c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   nds32le-linux-ld: net/8021q/vlan_dev.o: in function `vlan_ethtool_get_drvinfo':
>> vlan_dev.c:(.text+0x2e8): undefined reference to `vlan_fullname'
>> nds32le-linux-ld: vlan_dev.c:(.text+0x2ec): undefined reference to `vlan_fullname'
>> nds32le-linux-ld: vlan_dev.c:(.text+0x300): undefined reference to `vlan_version'
   nds32le-linux-ld: vlan_dev.c:(.text+0x304): undefined reference to `vlan_version'

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
diff mbox series

Patch

diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index f292e0267bb9..9f4b1b9a37e4 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -42,9 +42,6 @@ 
 
 unsigned int vlan_net_id __read_mostly;
 
-const char vlan_fullname[] = "802.1Q VLAN Support";
-const char vlan_version[] = DRV_VERSION;
-
 /* End of global variables definitions. */
 
 static int vlan_group_prealloc_vid(struct vlan_group *vg,
@@ -687,8 +684,6 @@  static int __init vlan_proto_init(void)
 {
 	int err;
 
-	pr_info("%s v%s\n", vlan_fullname, vlan_version);
-
 	err = register_pernet_subsys(&vlan_net_ops);
 	if (err < 0)
 		goto err0;