| Message ID | 20201209111933.16121-1-vee.khee.wong@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/1] net: stmmac: allow stmmac to probe for C45 PHY devices | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Wed, Dec 09, 2020 at 07:19:33PM +0800, Wong Vee Khee wrote: > Assign stmmac's mdio_bus probe capabilities to MDIOBUS_C22_C45. > This extends the probing of C45 PHY devices on the MDIO bus. > > Signed-off-by: Wong Vee Khee <vee.khee.wong@intel.com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > index b2a707e2ef43..9f96bb7d27db 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > @@ -364,6 +364,7 @@ int stmmac_mdio_register(struct net_device *ndev) > memcpy(new_bus->irq, mdio_bus_data->irqs, sizeof(new_bus->irq)); > > new_bus->name = "stmmac"; > + new_bus->probe_capabilities = MDIOBUS_C22_C45; It looks like this needs to be conditional on the version. xgmax2 supports C45. And gmac4. But other versions don't. Andrew
> -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: Thursday, December 10, 2020 12:09 AM > To: Wong, Vee Khee <vee.khee.wong@intel.com> > Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>; Alexandre Torgue > <alexandre.torgue@st.com>; Jose Abreu <joabreu@synopsys.com>; David > S . Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; > Maxime Coquelin <mcoquelin.stm32@gmail.com>; Voon, Weifeng > <weifeng.voon@intel.com>; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; Ong, Boon Leong <boon.leong.ong@intel.com>; > linux-stm32@st-md-mailman.stormreply.com; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH net-next 1/1] net: stmmac: allow stmmac to probe for > C45 PHY devices > > On Wed, Dec 09, 2020 at 07:19:33PM +0800, Wong Vee Khee wrote: > > Assign stmmac's mdio_bus probe capabilities to MDIOBUS_C22_C45. > > This extends the probing of C45 PHY devices on the MDIO bus. > > > > Signed-off-by: Wong Vee Khee <vee.khee.wong@intel.com> > > --- > > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > > index b2a707e2ef43..9f96bb7d27db 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > > @@ -364,6 +364,7 @@ int stmmac_mdio_register(struct net_device *ndev) > > memcpy(new_bus->irq, mdio_bus_data->irqs, > sizeof(new_bus->irq)); > > > > new_bus->name = "stmmac"; > > + new_bus->probe_capabilities = MDIOBUS_C22_C45; > > It looks like this needs to be conditional on the version. xgmax2 > supports C45. And gmac4. But other versions don't. > > Andrew I will send a v2 with conditional checking for gmac4. I do not have a xgmac2 hardware setup to test this.
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c index b2a707e2ef43..9f96bb7d27db 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c @@ -364,6 +364,7 @@ int stmmac_mdio_register(struct net_device *ndev) memcpy(new_bus->irq, mdio_bus_data->irqs, sizeof(new_bus->irq)); new_bus->name = "stmmac"; + new_bus->probe_capabilities = MDIOBUS_C22_C45; if (priv->plat->has_xgmac) { new_bus->read = &stmmac_xgmac2_mdio_read;
Assign stmmac's mdio_bus probe capabilities to MDIOBUS_C22_C45. This extends the probing of C45 PHY devices on the MDIO bus. Signed-off-by: Wong Vee Khee <vee.khee.wong@intel.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 1 + 1 file changed, 1 insertion(+)