| Message ID | 20201214091616.13545-7-Sergey.Semin@baikalelectronics.ru (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: stmmac: Fix clocks/reset-related procedures | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply |
On Mon, Dec 14, 2020 at 12:15:56PM +0300, Serge Semin wrote: > Generic DW *MAC can be connected to an external Tramit and Receive clock s/Tramit/Transmit/ > generators. Add the corresponding clocks description and clock-names to > the generic bindings schema so new DW *MAC-based bindings wouldn't declare > its own names of the same clocks. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index e1ebe5c8b1da..74820f491346 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -126,6 +126,18 @@ properties: > MCI, CSR and SMA interfaces run on this clock. If it's omitted, > the CSR interfaces are considered as synchronous to the system > clock domain. > + - description: > + GMAC Tx clock or so called Transmit clock. The clock is supplied > + by an external with respect to the DW MAC clock generator. > + The clock source and its frequency depends on the DW MAC xMII mode. > + In case if it's supplied by PHY/SerDes this property can be > + omitted. > + - description: > + GMAC Rx clock or so called Receive clock. The clock is supplied > + by an external with respect to the DW MAC clock generator. > + The clock source and its frequency depends on the DW MAC xMII mode. > + In case if it's supplied by PHY/SerDes or it's synchronous to > + the Tx clock this property can be omitted. > - description: > PTP reference clock. This clock is used for programming the > Timestamp Addend Register. If not passed then the system > @@ -139,6 +151,8 @@ properties: > enum: > - stmmaceth > - pclk > + - tx > + - rx > - ptp_ref > > resets: > -- > 2.29.2 >
On Mon, 14 Dec 2020 12:15:56 +0300, Serge Semin wrote: > Generic DW *MAC can be connected to an external Tramit and Receive clock > generators. Add the corresponding clocks description and clock-names to > the generic bindings schema so new DW *MAC-based bindings wouldn't declare > its own names of the same clocks. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Tue, Dec 15, 2020 at 11:32:04AM -0600, Rob Herring wrote: > On Mon, Dec 14, 2020 at 12:15:56PM +0300, Serge Semin wrote: > > Generic DW *MAC can be connected to an external Tramit and Receive clock > > s/Tramit/Transmit/ Thanks. I'll fix it in v2. -Sergey > > > generators. Add the corresponding clocks description and clock-names to > > the generic bindings schema so new DW *MAC-based bindings wouldn't declare > > its own names of the same clocks. > > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > --- > > .../devicetree/bindings/net/snps,dwmac.yaml | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index e1ebe5c8b1da..74820f491346 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -126,6 +126,18 @@ properties: > > MCI, CSR and SMA interfaces run on this clock. If it's omitted, > > the CSR interfaces are considered as synchronous to the system > > clock domain. > > + - description: > > + GMAC Tx clock or so called Transmit clock. The clock is supplied > > + by an external with respect to the DW MAC clock generator. > > + The clock source and its frequency depends on the DW MAC xMII mode. > > + In case if it's supplied by PHY/SerDes this property can be > > + omitted. > > + - description: > > + GMAC Rx clock or so called Receive clock. The clock is supplied > > + by an external with respect to the DW MAC clock generator. > > + The clock source and its frequency depends on the DW MAC xMII mode. > > + In case if it's supplied by PHY/SerDes or it's synchronous to > > + the Tx clock this property can be omitted. > > - description: > > PTP reference clock. This clock is used for programming the > > Timestamp Addend Register. If not passed then the system > > @@ -139,6 +151,8 @@ properties: > > enum: > > - stmmaceth > > - pclk > > + - tx > > + - rx > > - ptp_ref > > > > resets: > > -- > > 2.29.2 > >
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index e1ebe5c8b1da..74820f491346 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -126,6 +126,18 @@ properties: MCI, CSR and SMA interfaces run on this clock. If it's omitted, the CSR interfaces are considered as synchronous to the system clock domain. + - description: + GMAC Tx clock or so called Transmit clock. The clock is supplied + by an external with respect to the DW MAC clock generator. + The clock source and its frequency depends on the DW MAC xMII mode. + In case if it's supplied by PHY/SerDes this property can be + omitted. + - description: + GMAC Rx clock or so called Receive clock. The clock is supplied + by an external with respect to the DW MAC clock generator. + The clock source and its frequency depends on the DW MAC xMII mode. + In case if it's supplied by PHY/SerDes or it's synchronous to + the Tx clock this property can be omitted. - description: PTP reference clock. This clock is used for programming the Timestamp Addend Register. If not passed then the system @@ -139,6 +151,8 @@ properties: enum: - stmmaceth - pclk + - tx + - rx - ptp_ref resets:
Generic DW *MAC can be connected to an external Tramit and Receive clock generators. Add the corresponding clocks description and clock-names to the generic bindings schema so new DW *MAC-based bindings wouldn't declare its own names of the same clocks. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> --- .../devicetree/bindings/net/snps,dwmac.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+)