| Message ID | 20201222222637.3204929-3-robert.marko@sartura.hr (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add support for Qualcomm QCA807x PHYs | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 9 of 9 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 1 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
> + gpio-controller: true > + "#gpio-cells": > + const: 2 > + > + qcom,single-led-1000: > + description: | > + If present, then dedicated 1000 Mbit will light up for 1000Base-T. > + This is a workround for boards with a single LED instead of two. > + type: boolean > + > + qcom,single-led-100: > + description: | > + If present, then dedicated 1000 Mbit will light up for 100Base-TX. > + This is a workround for boards with a single LED instead of two. > + type: boolean > + > + qcom,single-led-10: > + description: | > + If present, then dedicated 1000 Mbit will light up for 10Base-Te. > + This is a workround for boards with a single LED instead of two. > + type: boolean Sorry, but no. Please look at the work being done for allow PHY LEDs to be controlled via the LED subsystem. > + qcom,tx-driver-strength: > + description: PSGMII/QSGMII TX driver strength control. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12] Please use the actual values here, and have the driver convert to the value poked into the register. So the property would be qcom,tx-driver-strength-mv and it would have the value 220 for example. > + > + qcom,control-dac: > + description: Analog MDI driver amplitude and bias current. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1, 2, 3, 4, 5, 6, 7] Make here. Andrew
On Wed, Dec 23, 2020 at 01:56:33AM +0100, Andrew Lunn wrote: > > + gpio-controller: true > > + "#gpio-cells": > > + const: 2 > > + > > + qcom,single-led-1000: > > + description: | > > + If present, then dedicated 1000 Mbit will light up for 1000Base-T. > > + This is a workround for boards with a single LED instead of two. > > + type: boolean > > + > > + qcom,single-led-100: > > + description: | > > + If present, then dedicated 1000 Mbit will light up for 100Base-TX. > > + This is a workround for boards with a single LED instead of two. > > + type: boolean > > + > > + qcom,single-led-10: > > + description: | > > + If present, then dedicated 1000 Mbit will light up for 10Base-Te. > > + This is a workround for boards with a single LED instead of two. > > + type: boolean > > Sorry, but no. Please look at the work being done for allow PHY LEDs > to be controlled via the LED subsystem. > > > + qcom,tx-driver-strength: > > + description: PSGMII/QSGMII TX driver strength control. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12] > > Please use the actual values here, and have the driver convert to the > value poked into the register. So the property would be > qcom,tx-driver-strength-mv and it would have the value 220 for > example. The LED binding has properties for specifying the current already. And it's max current which is the h/w property where as anything less is just software configuration (IOW, doesn't belong in DT).
> > > + qcom,tx-driver-strength: > > > + description: PSGMII/QSGMII TX driver strength control. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12] > > > > Please use the actual values here, and have the driver convert to the > > value poked into the register. So the property would be > > qcom,tx-driver-strength-mv and it would have the value 220 for > > example. > > The LED binding has properties for specifying the current already. And > it's max current which is the h/w property where as anything less is > just software configuration (IOW, doesn't belong in DT). Hi Rob My understanding of this is it is the drive strength of the SERDES line. Nothing to do with LEDs. The description needs improving. Andrew
On Wed, Dec 23, 2020 at 1:56 AM Andrew Lunn <andrew@lunn.ch> wrote: > > > + gpio-controller: true > > + "#gpio-cells": > > + const: 2 > > + > > + qcom,single-led-1000: > > + description: | > > + If present, then dedicated 1000 Mbit will light up for 1000Base-T. > > + This is a workround for boards with a single LED instead of two. > > + type: boolean > > + > > + qcom,single-led-100: > > + description: | > > + If present, then dedicated 1000 Mbit will light up for 100Base-TX. > > + This is a workround for boards with a single LED instead of two. > > + type: boolean > > + > > + qcom,single-led-10: > > + description: | > > + If present, then dedicated 1000 Mbit will light up for 10Base-Te. > > + This is a workround for boards with a single LED instead of two. > > + type: boolean > > Sorry, but no. Please look at the work being done for allow PHY LEDs > to be controlled via the LED subsystem. Ok, I will drop the LED configuration from the driver until there is a generic way to do it. I was following the work on it, but it seems to have halted after September. > > > + qcom,tx-driver-strength: > > + description: PSGMII/QSGMII TX driver strength control. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12] > > Please use the actual values here, and have the driver convert to the > value poked into the register. So the property would be > qcom,tx-driver-strength-mv and it would have the value 220 for > example. Ok, it actually makes more sense than using dt-binding includes for this. > > > + > > + qcom,control-dac: > > + description: Analog MDI driver amplitude and bias current. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [0, 1, 2, 3, 4, 5, 6, 7] > > Make here. I am using defines in dt-binding includes for this one as it makes the values humanly readable in DT as these configure the amplitude and bias current for power saving. > > Andrew
On Sun, Jan 3, 2021 at 6:00 PM Andrew Lunn <andrew@lunn.ch> wrote: > > > > > + qcom,tx-driver-strength: > > > > + description: PSGMII/QSGMII TX driver strength control. > > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12] > > > > > > Please use the actual values here, and have the driver convert to the > > > value poked into the register. So the property would be > > > qcom,tx-driver-strength-mv and it would have the value 220 for > > > example. > > > > The LED binding has properties for specifying the current already. And > > it's max current which is the h/w property where as anything less is > > just software configuration (IOW, doesn't belong in DT). > > Hi Rob > > My understanding of this is it is the drive strength of the SERDES > line. Nothing to do with LEDs. The description needs improving. Yes, this is used to set the PSGMII/QSMII SerDes TX driver strength. It has nothing to do with LEDs. I agree that the description is a bit confusing, I will try to make it a bit clearer. > > Andrew
diff --git a/Documentation/devicetree/bindings/net/qcom,qca807x.yaml b/Documentation/devicetree/bindings/net/qcom,qca807x.yaml new file mode 100644 index 000000000000..87e093ad4193 --- /dev/null +++ b/Documentation/devicetree/bindings/net/qcom,qca807x.yaml @@ -0,0 +1,88 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/qcom,qca807x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm QCA807x PHY + +maintainers: + - Robert Marko <robert.marko@sartura.hr> + +description: | + Bindings for Qualcomm QCA807x PHYs + +allOf: + - $ref: ethernet-phy.yaml# + +properties: + reg: + maxItems: 1 + + qcom,fiber-enable: + description: | + If present, then PHYs combo port is configured to operate in combo + mode. In combo mode autodetection of copper and fiber media is + used in order to support both of them. + Combo mode can be strapped as well, if not strapped this property + will set combo support anyway. + type: boolean + + qcom,psgmii-az: + description: | + If present, then PSMGII PHY will advertise 802.3-az support to + the MAC. + type: boolean + + gpio-controller: true + "#gpio-cells": + const: 2 + + qcom,single-led-1000: + description: | + If present, then dedicated 1000 Mbit will light up for 1000Base-T. + This is a workround for boards with a single LED instead of two. + type: boolean + + qcom,single-led-100: + description: | + If present, then dedicated 1000 Mbit will light up for 100Base-TX. + This is a workround for boards with a single LED instead of two. + type: boolean + + qcom,single-led-10: + description: | + If present, then dedicated 1000 Mbit will light up for 10Base-Te. + This is a workround for boards with a single LED instead of two. + type: boolean + + qcom,tx-driver-strength: + description: PSGMII/QSGMII TX driver strength control. + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12] + + qcom,control-dac: + description: Analog MDI driver amplitude and bias current. + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [0, 1, 2, 3, 4, 5, 6, 7] + +required: + - reg + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/net/qcom-qca807x.h> + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethphy0: ethernet-phy@0 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0>; + + qcom,control-dac = <QCA807X_CONTROL_DAC_DSP_VOLT_QUARTER_BIAS>; + }; + };
Add DT bindings for Qualcomm QCA807x PHYs. Signed-off-by: Robert Marko <robert.marko@sartura.hr> Cc: Luka Perkov <luka.perkov@sartura.hr> --- .../devicetree/bindings/net/qcom,qca807x.yaml | 88 +++++++++++++++++++ 1 file changed, 88 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/qcom,qca807x.yaml