| Message ID | 20210106021815.31796-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7f847db3040897f3ee25ce97265c545b5561f6c2 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: fix led_classdev build errors | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 4 maintainers not CCed: f.fainelli@gmail.com vivien.didelot@gmail.com andrew@lunn.ch olteanv@gmail.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 5 Jan 2021 18:18:15 -0800 you wrote: > Fix build errors when LEDS_CLASS=m and NET_DSA_HIRSCHMANN_HELLCREEK=y. > This limits the latter to =m when LEDS_CLASS=m. > > microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function `hellcreek_ptp_setup': > (.text+0xf80): undefined reference to `led_classdev_register_ext' > microblaze-linux-ld: (.text+0xf94): undefined reference to `led_classdev_register_ext' > microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function `hellcreek_ptp_free': > (.text+0x1018): undefined reference to `led_classdev_unregister' > microblaze-linux-ld: (.text+0x1024): undefined reference to `led_classdev_unregister' > > [...] Here is the summary with links: - net: dsa: fix led_classdev build errors https://git.kernel.org/netdev/net/c/7f847db30408 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
On Tue Jan 05 2021, Randy Dunlap wrote: > Fix build errors when LEDS_CLASS=m and NET_DSA_HIRSCHMANN_HELLCREEK=y. > This limits the latter to =m when LEDS_CLASS=m. > > microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function `hellcreek_ptp_setup': > (.text+0xf80): undefined reference to `led_classdev_register_ext' > microblaze-linux-ld: (.text+0xf94): undefined reference to `led_classdev_register_ext' > microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function `hellcreek_ptp_free': > (.text+0x1018): undefined reference to `led_classdev_unregister' > microblaze-linux-ld: (.text+0x1024): undefined reference to `led_classdev_unregister' > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Link: lore.kernel.org/r/202101060655.iUvMJqS2-lkp@intel.com > Cc: Kurt Kanzenbach <kurt@linutronix.de> > Cc: netdev@vger.kernel.org > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> Fixes: 7d9ee2e8ff15 ("net: dsa: hellcreek: Add PTP status LEDs") Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de> Thanks, Kurt
--- lnx-511-rc2.orig/drivers/net/dsa/hirschmann/Kconfig +++ lnx-511-rc2/drivers/net/dsa/hirschmann/Kconfig @@ -4,6 +4,7 @@ config NET_DSA_HIRSCHMANN_HELLCREEK depends on HAS_IOMEM depends on NET_DSA depends on PTP_1588_CLOCK + depends on LEDS_CLASS select NET_DSA_TAG_HELLCREEK help This driver adds support for Hirschmann Hellcreek TSN switches.
Fix build errors when LEDS_CLASS=m and NET_DSA_HIRSCHMANN_HELLCREEK=y. This limits the latter to =m when LEDS_CLASS=m. microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function `hellcreek_ptp_setup': (.text+0xf80): undefined reference to `led_classdev_register_ext' microblaze-linux-ld: (.text+0xf94): undefined reference to `led_classdev_register_ext' microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function `hellcreek_ptp_free': (.text+0x1018): undefined reference to `led_classdev_unregister' microblaze-linux-ld: (.text+0x1024): undefined reference to `led_classdev_unregister' Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Link: lore.kernel.org/r/202101060655.iUvMJqS2-lkp@intel.com Cc: Kurt Kanzenbach <kurt@linutronix.de> Cc: netdev@vger.kernel.org Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> --- drivers/net/dsa/hirschmann/Kconfig | 1 + 1 file changed, 1 insertion(+)