From patchwork Wed Jan 6 13:10:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 12001573 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC7C8C433E0 for ; Wed, 6 Jan 2021 13:11:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C556023100 for ; Wed, 6 Jan 2021 13:11:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726893AbhAFNLl (ORCPT ); Wed, 6 Jan 2021 08:11:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726439AbhAFNLi (ORCPT ); Wed, 6 Jan 2021 08:11:38 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A809C06135F for ; Wed, 6 Jan 2021 05:10:31 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id y24so4292061edt.10 for ; Wed, 06 Jan 2021 05:10:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7y/AWARlC0SfYNtW9no7XIENGToj9zK6j7J53BXQxNM=; b=vgqBLloFpZEI+mEUA7MZXNQsMj4UZm23QFlpiS/yTAcN3oX2vSL0oG6336v3eRUHvJ 4suvTC/T50FqSzgWjGRNDEjsd7k3hkf7Jn2Xp+OgRXug8tcAxZSL4f8x5JENYqCY/zqG svALDaFrNZNNBdyJ4Tl0YMIjQFXU17LhN//7P7uUuKMiiRqttZtbY0tkrxK51LXm5/aI 9+KKflesWbW2qxsormM7tvIKQHZGdf0qUk0K+Uj6M9MS4h25wNuy1rJ19s3h7hgcvnWC I9BSIAtO43DP90HbPRy6C3/oJjh+LZdwInOn4KiYLLslfOE1q2lZBS24QtUA83JVsC9Z os5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7y/AWARlC0SfYNtW9no7XIENGToj9zK6j7J53BXQxNM=; b=uKzPEUXcOT0Mi3C60cGc8pZ8lDJWOcOTHUG0oCW4hHeF8kSzc7EIHXXwhNFbBf8GoQ DMQLLERCF0//D1bYn1TSAnQdE1JKPKZq04ja88q+zifNxGgZNBns6092swuh86veN3w0 Tr2rPvmS5KzeEyDK8NLXyJTeaSq4nfUm4wN4cSeTMY/26RGIq7TZFiKAQr3s3Kx7iHkK HLVJEMzqpavJ92+QMEvYwAEti4z6isyZSA/2MIVhJkXNJjM91sUshstTQJwO96J0JsEK eTlRgAZhUKVxNpPyL1Pww+THQstKKhV3W99ddM2Y+LIY2JvkGPJ9kPqBZXfvIMON7NGp 24Zw== X-Gm-Message-State: AOAM532lYBqPUYZdz+tmWthrGXNvr2Lbs+JD6OVtyWGXHkYzSlldZl74 lUuOgOR4moO6RE2wPlhc/YvzYpR77GoOqQ== X-Google-Smtp-Source: ABdhPJxpmKnQ9I4InQ3nBSWeADTgJlnKF+7uL8yNR/bO8YTuFV9WwDwOzt/zBbzntp3bHzKLquhMlA== X-Received: by 2002:a50:8e19:: with SMTP id 25mr3901447edw.263.1609938629991; Wed, 06 Jan 2021 05:10:29 -0800 (PST) Received: from localhost.localdomain (5-12-227-87.residential.rdsnet.ro. [5.12.227.87]) by smtp.gmail.com with ESMTPSA id p22sm1241858ejx.59.2021.01.06.05.10.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jan 2021 05:10:29 -0800 (PST) From: Vladimir Oltean To: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , Microchip Linux Driver Support , Sean Wang , Landen Chao , Claudiu Manoil , Alexandre Belloni , Linus Walleij , Vadym Kochan , Taras Chornyi , Jiri Pirko , Ido Schimmel , Grygorii Strashko , Ioana Ciornei , Ivan Vecera Subject: [PATCH v2 net-next 08/10] net: dsa: remove obsolete comments about switchdev transactions Date: Wed, 6 Jan 2021 15:10:04 +0200 Message-Id: <20210106131006.577312-9-olteanv@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210106131006.577312-1-olteanv@gmail.com> References: <20210106131006.577312-1-olteanv@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Vladimir Oltean Now that all port object notifiers were converted to be non-transactional, we can remove the comments that say otherwise. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Acked-by: Linus Walleij Acked-by: Jiri Pirko --- Changes in v2: None. net/dsa/slave.c | 5 ----- net/dsa/switch.c | 4 ---- 2 files changed, 9 deletions(-) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 4f0aae1192e5..963607547ab3 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -373,11 +373,6 @@ static int dsa_slave_port_obj_add(struct net_device *dev, struct dsa_port *dp = dsa_slave_to_port(dev); int err; - /* For the prepare phase, ensure the full set of changes is feasable in - * one go in order to signal a failure properly. If an operation is not - * supported, return -EOPNOTSUPP. - */ - switch (obj->id) { case SWITCHDEV_OBJ_ID_PORT_MDB: if (obj->orig_dev != dev) diff --git a/net/dsa/switch.c b/net/dsa/switch.c index f92eaacb17cf..21d2f842d068 100644 --- a/net/dsa/switch.c +++ b/net/dsa/switch.c @@ -298,10 +298,6 @@ static int dsa_switch_event(struct notifier_block *nb, break; } - /* Non-switchdev operations cannot be rolled back. If a DSA driver - * returns an error during the chained call, switch chips may be in an - * inconsistent state. - */ if (err) dev_dbg(ds->dev, "breaking chain for DSA event %lu (%d)\n", event, err);