| Message ID | 20210106191546.1358324-1-f.fainelli@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: broadcom: Drop OF dependency from BGMAC_PLATFORM | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On 1/6/21 11:15 AM, Florian Fainelli wrote: > All of the OF code that is used has stubbed and will compile and link > just fine, keeping COMPILE_TEST is enough. Yes, that matches my understanding. I wish we had a list of which API families have full stub support... Acked-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/net/ethernet/broadcom/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig > index 7b79528d6eed..4bdf8fbe75a6 100644 > --- a/drivers/net/ethernet/broadcom/Kconfig > +++ b/drivers/net/ethernet/broadcom/Kconfig > @@ -174,7 +174,6 @@ config BGMAC_BCMA > config BGMAC_PLATFORM > tristate "Broadcom iProc GBit platform support" > depends on ARCH_BCM_IPROC || COMPILE_TEST > - depends on OF > select BGMAC > select PHYLIB > select FIXED_PHY >
On Wed, 6 Jan 2021 11:27:29 -0800 Randy Dunlap wrote: > On 1/6/21 11:15 AM, Florian Fainelli wrote: > > All of the OF code that is used has stubbed and will compile and link > > just fine, keeping COMPILE_TEST is enough. > > Yes, that matches my understanding. > > I wish we had a list of which API families have full stub support... > > Acked-by: Randy Dunlap <rdunlap@infradead.org> Applied, thanks!
diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig index 7b79528d6eed..4bdf8fbe75a6 100644 --- a/drivers/net/ethernet/broadcom/Kconfig +++ b/drivers/net/ethernet/broadcom/Kconfig @@ -174,7 +174,6 @@ config BGMAC_BCMA config BGMAC_PLATFORM tristate "Broadcom iProc GBit platform support" depends on ARCH_BCM_IPROC || COMPILE_TEST - depends on OF select BGMAC select PHYLIB select FIXED_PHY
All of the OF code that is used has stubbed and will compile and link just fine, keeping COMPILE_TEST is enough. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- drivers/net/ethernet/broadcom/Kconfig | 1 - 1 file changed, 1 deletion(-)