From patchwork Thu Jan 7 09:49:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 12003445 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3562DC43381 for ; Thu, 7 Jan 2021 09:52:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E99762333E for ; Thu, 7 Jan 2021 09:52:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728003AbhAGJwP (ORCPT ); Thu, 7 Jan 2021 04:52:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727905AbhAGJvr (ORCPT ); Thu, 7 Jan 2021 04:51:47 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3C81C0612FC for ; Thu, 7 Jan 2021 01:51:12 -0800 (PST) Received: by mail-ej1-x62f.google.com with SMTP id n26so8850699eju.6 for ; Thu, 07 Jan 2021 01:51:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UgBhBVpzz6m5FwdjCW5WUOkWO3FR/vyy7c45RHmTols=; b=GrWdCYXFw/CxDEhhIsLb/y4hC63LQ5zFthNin1HkzlYR6kET6fnohgx/MwALBxPihF 6rfBP9MWT9NSJqIkqdOxLmUMgV5wIPvq89t0aEmcsoBICRM12Gz4Iqx3xkbhfhYrx/S0 OHO+0d60fFr0bB1u+YFSxPEYwA7en6Gs9GP5saAmXSfN4Sho5tX/6ErEzmvg9I8bKcwV 5yID9czjqiUuKAiePCTJrRKx21ryEzd/QpWWY0b+VeFWaOhPqzPq5he4jv7djy+1YzkQ SP4LmvrZjwOiQ26VS6bGKoxLzXpNxaq0z1p7mK11Zre72KJFkZTah1LlWioMy3rImRXE o5Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UgBhBVpzz6m5FwdjCW5WUOkWO3FR/vyy7c45RHmTols=; b=e0X8Jx0zlkivTTwzlVJKmPTCkZf8L7FdXRyi9fjbVCnfPiYTd417lMTeNmlY0TKz2e fYlUjtUB04gOQRQXokYmsqlPgYVfDv1gzptNFCWUbs84XMwsqfB9xio3jCYPpHJ1SsZU 3zZB1eHeYx6/kBipI8MEllsKMkVU1jl7dCtE6c9zwNy7Rj4ITC15XZvDAelb0dcOuPX6 QmYo1nMKdsqctGmfqMBJef5JHUUYXJUjbv8Ku39N+ZzEx6tptEM53YBQXuD4RRg6JpcU ql5E+pUwh7Wq4QEw+bseIk51S0mM1NT15l0h2ogGlZ1mNx7geu5ozfk8HOh+/19okNat CWug== X-Gm-Message-State: AOAM530z0OwVMXHxxC4jQiag/zRklhrq/I10DIW4oAufmp2MQRF56Tr0 cRF6bRpdM0hLz4LMh5P7EY0= X-Google-Smtp-Source: ABdhPJx3EDiVZs9u5xtTHQLV9r9T+7dUZo4LQMRe1iWkqpXy8xblsKTvM5Hwlxd0yKn+810KQ2h1xQ== X-Received: by 2002:a17:906:d146:: with SMTP id br6mr5629615ejb.331.1610013071776; Thu, 07 Jan 2021 01:51:11 -0800 (PST) Received: from localhost.localdomain (5-12-227-87.residential.rdsnet.ro. [5.12.227.87]) by smtp.gmail.com with ESMTPSA id k15sm2251571ejc.79.2021.01.07.01.51.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jan 2021 01:51:11 -0800 (PST) From: Vladimir Oltean To: "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Cong Wang , Stephen Hemminger , Eric Dumazet , George McCollister , Oleksij Rempel , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , Arnd Bergmann , Taehee Yoo , Jiri Pirko , Florian Westphal Subject: [PATCH v3 net-next 06/12] parisc/led: reindent the code that gathers device statistics Date: Thu, 7 Jan 2021 11:49:45 +0200 Message-Id: <20210107094951.1772183-7-olteanv@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210107094951.1772183-1-olteanv@gmail.com> References: <20210107094951.1772183-1-olteanv@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Vladimir Oltean The standard in the Linux kernel is to use one tab character per indentation level. Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: linux-parisc@vger.kernel.org Signed-off-by: Vladimir Oltean --- Changes in v3: None. Changes in v2: None. drivers/parisc/led.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/parisc/led.c b/drivers/parisc/led.c index 36c6613f7a36..3cada632a4be 100644 --- a/drivers/parisc/led.c +++ b/drivers/parisc/led.c @@ -359,16 +359,19 @@ static __inline__ int led_get_net_activity(void) /* we are running as a workqueue task, so we can use an RCU lookup */ rcu_read_lock(); for_each_netdev_rcu(&init_net, dev) { - const struct rtnl_link_stats64 *stats; - struct rtnl_link_stats64 temp; - struct in_device *in_dev = __in_dev_get_rcu(dev); - if (!in_dev || !in_dev->ifa_list) - continue; - if (ipv4_is_loopback(in_dev->ifa_list->ifa_local)) - continue; - stats = dev_get_stats(dev, &temp); - rx_total += stats->rx_packets; - tx_total += stats->tx_packets; + const struct rtnl_link_stats64 *stats; + struct rtnl_link_stats64 temp; + struct in_device *in_dev = __in_dev_get_rcu(dev); + + if (!in_dev || !in_dev->ifa_list) + continue; + + if (ipv4_is_loopback(in_dev->ifa_list->ifa_local)) + continue; + + stats = dev_get_stats(dev, &temp); + rx_total += stats->rx_packets; + tx_total += stats->tx_packets; } rcu_read_unlock();