diff mbox series

[6/6] dpaa2-mac: remove a comment regarding pause settings

Message ID 20210107153638.753942-7-ciorneiioana@gmail.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series dpaa2-mac: various updates | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Guessed tree name to be net-next
netdev/subject_prefix success Link
netdev/cc_maintainers warning 1 maintainers not CCed: ruxandra.radulescu@nxp.com
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 9 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success Link
netdev/stable success Stable not CCed

Commit Message

Ioana Ciornei Jan. 7, 2021, 3:36 p.m. UTC 
From: Ioana Ciornei <ioana.ciornei@nxp.com>

The pause settings are not actually lossy since the MC firmware was does
is to transform back these pause/asym-pause flags into rx/tx pause
enablement status. We are not losing information by this transformation,
thus remove the comment.

Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
 drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Andrew Lunn Jan. 7, 2021, 9:26 p.m. UTC | #1 
On Thu, Jan 07, 2021 at 05:36:38PM +0200, Ioana Ciornei wrote:
> From: Ioana Ciornei <ioana.ciornei@nxp.com>
> 
> The pause settings are not actually lossy since the MC firmware was does
> is

was does is?

    Andrew
Ioana Ciornei Jan. 7, 2021, 9:37 p.m. UTC | #2 
On Thu, Jan 07, 2021 at 10:26:28PM +0100, Andrew Lunn wrote:
> On Thu, Jan 07, 2021 at 05:36:38PM +0200, Ioana Ciornei wrote:
> > From: Ioana Ciornei <ioana.ciornei@nxp.com>
> > 
> > The pause settings are not actually lossy since the MC firmware was does
> > is
> 
> was does is?
> 

It was supposed to be 'what does is'...

Even so, I'll reword it.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
index 40aa81eb3c4b..f76adbe8c32b 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
@@ -181,9 +181,6 @@  static void dpaa2_mac_link_up(struct phylink_config *config,
 	else if (duplex == DUPLEX_FULL)
 		dpmac_state->options &= ~DPMAC_LINK_OPT_HALF_DUPLEX;
 
-	/* This is lossy; the firmware really should take the pause
-	 * enablement status rather than pause/asym pause status.
-	 */
 	if (rx_pause)
 		dpmac_state->options |= DPMAC_LINK_OPT_PAUSE;
 	else