From patchwork Mon Jan 11 18:29:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Lobakin X-Patchwork-Id: 12011381 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DADEC433E9 for ; Mon, 11 Jan 2021 18:29:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E288F2250E for ; Mon, 11 Jan 2021 18:29:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390518AbhAKS3s (ORCPT ); Mon, 11 Jan 2021 13:29:48 -0500 Received: from mail-40134.protonmail.ch ([185.70.40.134]:16187 "EHLO mail-40134.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390502AbhAKS3r (ORCPT ); Mon, 11 Jan 2021 13:29:47 -0500 Date: Mon, 11 Jan 2021 18:29:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1610389745; bh=uLN743u/wqC/gFFuGPFTwvMOdJ2kjErr9WqlX51ROd4=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=nkuQl8J/da2u0Tmb+7OxCZKNk/wFExeqrMkX5jgpkqnU+jSg6DqQjd6fHnytlLjUZ Qq1kC/v0PSwTbZe+uPUjwnnrFgnV3xb9mIcRVucIkZaA5u6jAiuO3zKw1nS30pIFgx JhKH/V3eBxsc5KHmPKrKViFH0mRAjmD4hxD6mDzMrOPgf2JJzIdB9i5qM3jVvRvopq eqBFwDzQZYsk1pelTAGCJRLjb1STPtge7qU3qLsc6xxv8JfQeqBfT1aFAaWB6hU/Fq xdq383aD6ZHBBE9XLXWbWYrKRt+fTepkRePEZQBy/BUXTHTgf0dnrZerIjgHq2JTWr MB0QOp3VQR+KQ== To: "David S. Miller" , Jakub Kicinski From: Alexander Lobakin Cc: Eric Dumazet , Edward Cree , Jonathan Lemon , Willem de Bruijn , Miaohe Lin , Alexander Lobakin , Steffen Klassert , Guillaume Nault , Yadu Kishore , Al Viro , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: Alexander Lobakin Subject: [PATCH net-next 3/5] skbuff: reuse skbuff_heads from flush_skb_cache if available Message-ID: <20210111182801.12609-3-alobakin@pm.me> In-Reply-To: <20210111182801.12609-1-alobakin@pm.me> References: <20210111182655.12159-1-alobakin@pm.me> <20210111182801.12609-1-alobakin@pm.me> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Instead of unconditional allocating a new skbuff_head and unconditional flushing of flush_skb_cache, reuse the ones queued up for flushing if there are any. skbuff_heads stored in flush_skb_cache are already unreferenced from any pages or extensions and almost ready for use. We perform zeroing in __napi_alloc_skb() anyway, regardless of where did our skbuff_head came from. Signed-off-by: Alexander Lobakin --- net/core/skbuff.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 3c904c29efbb..0e8c597ff6ce 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -487,6 +487,9 @@ EXPORT_SYMBOL(__netdev_alloc_skb); static struct sk_buff *__napi_decache_skb(struct napi_alloc_cache *nc) { + if (nc->flush_skb_count) + return nc->flush_skb_cache[--nc->flush_skb_count]; + return kmem_cache_alloc(skbuff_head_cache, GFP_ATOMIC); }