| Message ID | 20210112192134.493-1-elder@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 46e05e1df628ab054486eafcc06a3c6512b338a1 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ipa: add config dependency on QCOM_SMEM | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 1 maintainers not CCed: elder@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On 1/12/21 11:21 AM, Alex Elder wrote: > The IPA driver depends on some SMEM functionality (qcom_smem_init(), > qcom_smem_alloc(), and qcom_smem_virt_to_phys()), but this is not > reflected in the configuration dependencies. Add a dependency on > QCOM_SMEM to avoid attempts to build the IPA driver without SMEM. > This avoids a link error for certain configurations. > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Fixes: 38a4066f593c5 ("net: ipa: support COMPILE_TEST") > Signed-off-by: Alex Elder <elder@linaro.org> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Thanks. > --- > drivers/net/ipa/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig > index 10a0e041ee775..b68f1289b89ef 100644 > --- a/drivers/net/ipa/Kconfig > +++ b/drivers/net/ipa/Kconfig > @@ -1,6 +1,6 @@ > config QCOM_IPA > tristate "Qualcomm IPA support" > - depends on 64BIT && NET > + depends on 64BIT && NET && QCOM_SMEM > depends on ARCH_QCOM || COMPILE_TEST > depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) > select QCOM_MDT_LOADER if ARCH_QCOM >
On Tue 12 Jan 13:21 CST 2021, Alex Elder wrote: > The IPA driver depends on some SMEM functionality (qcom_smem_init(), > qcom_smem_alloc(), and qcom_smem_virt_to_phys()), but this is not > reflected in the configuration dependencies. Add a dependency on > QCOM_SMEM to avoid attempts to build the IPA driver without SMEM. > This avoids a link error for certain configurations. > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Fixes: 38a4066f593c5 ("net: ipa: support COMPILE_TEST") > Signed-off-by: Alex Elder <elder@linaro.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/net/ipa/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig > index 10a0e041ee775..b68f1289b89ef 100644 > --- a/drivers/net/ipa/Kconfig > +++ b/drivers/net/ipa/Kconfig > @@ -1,6 +1,6 @@ > config QCOM_IPA > tristate "Qualcomm IPA support" > - depends on 64BIT && NET > + depends on 64BIT && NET && QCOM_SMEM > depends on ARCH_QCOM || COMPILE_TEST > depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) > select QCOM_MDT_LOADER if ARCH_QCOM > -- > 2.20.1 >
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 12 Jan 2021 13:21:34 -0600 you wrote: > The IPA driver depends on some SMEM functionality (qcom_smem_init(), > qcom_smem_alloc(), and qcom_smem_virt_to_phys()), but this is not > reflected in the configuration dependencies. Add a dependency on > QCOM_SMEM to avoid attempts to build the IPA driver without SMEM. > This avoids a link error for certain configurations. > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Fixes: 38a4066f593c5 ("net: ipa: support COMPILE_TEST") > Signed-off-by: Alex Elder <elder@linaro.org> > > [...] Here is the summary with links: - [net-next] net: ipa: add config dependency on QCOM_SMEM https://git.kernel.org/netdev/net-next/c/46e05e1df628 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig index 10a0e041ee775..b68f1289b89ef 100644 --- a/drivers/net/ipa/Kconfig +++ b/drivers/net/ipa/Kconfig @@ -1,6 +1,6 @@ config QCOM_IPA tristate "Qualcomm IPA support" - depends on 64BIT && NET + depends on 64BIT && NET && QCOM_SMEM depends on ARCH_QCOM || COMPILE_TEST depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) select QCOM_MDT_LOADER if ARCH_QCOM
The IPA driver depends on some SMEM functionality (qcom_smem_init(), qcom_smem_alloc(), and qcom_smem_virt_to_phys()), but this is not reflected in the configuration dependencies. Add a dependency on QCOM_SMEM to avoid attempts to build the IPA driver without SMEM. This avoids a link error for certain configurations. Reported-by: Randy Dunlap <rdunlap@infradead.org> Fixes: 38a4066f593c5 ("net: ipa: support COMPILE_TEST") Signed-off-by: Alex Elder <elder@linaro.org> --- drivers/net/ipa/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)