| Message ID | 20210119025930.2810532-1-liuhangbin@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] selftests/net/fib_tests: remove duplicate log test | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 4 maintainers not CCed: shuah@kernel.org davem@davemloft.net kuba@kernel.org linux-kselftest@vger.kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On 1/18/21 7:59 PM, Hangbin Liu wrote: > The previous test added an address with a specified metric and check if > correspond route was created. I somehow added two logs for the same > test. Remove the duplicated one. > > Reported-by: Antoine Tenart <atenart@redhat.com> > Fixes: 0d29169a708b ("selftests/net/fib_tests: update addr_metric_test for peer route testing") > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> > --- > tools/testing/selftests/net/fib_tests.sh | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: David Ahern <dsahern@kernel.org>
On Mon, 18 Jan 2021 20:03:12 -0700 David Ahern wrote: > On 1/18/21 7:59 PM, Hangbin Liu wrote: > > The previous test added an address with a specified metric and check if > > correspond route was created. I somehow added two logs for the same > > test. Remove the duplicated one. > > > > Reported-by: Antoine Tenart <atenart@redhat.com> > > Fixes: 0d29169a708b ("selftests/net/fib_tests: update addr_metric_test for peer route testing") > > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> > > --- > > tools/testing/selftests/net/fib_tests.sh | 1 - > > 1 file changed, 1 deletion(-) > > > > Reviewed-by: David Ahern <dsahern@kernel.org> Applied, thanks!
diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh index 84205c3a55eb..2b5707738609 100755 --- a/tools/testing/selftests/net/fib_tests.sh +++ b/tools/testing/selftests/net/fib_tests.sh @@ -1055,7 +1055,6 @@ ipv6_addr_metric_test() check_route6 "2001:db8:104::1 dev dummy2 proto kernel metric 260" log_test $? 0 "Set metric with peer route on local side" - log_test $? 0 "User specified metric on local address" check_route6 "2001:db8:104::2 dev dummy2 proto kernel metric 260" log_test $? 0 "Set metric with peer route on peer side"
The previous test added an address with a specified metric and check if correspond route was created. I somehow added two logs for the same test. Remove the duplicated one. Reported-by: Antoine Tenart <atenart@redhat.com> Fixes: 0d29169a708b ("selftests/net/fib_tests: update addr_metric_test for peer route testing") Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> --- tools/testing/selftests/net/fib_tests.sh | 1 - 1 file changed, 1 deletion(-)