| Message ID | 20210122143524.14516-2-laurentbadel@eaton.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: phy: Fix interrupt mask loss on resume from hibernation | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | fail | Series targets non-next tree, but doesn't contain any Fixes tags |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | fail | ERROR: that open brace { should be on the previous line |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 80c2e646c093..5070eed55447 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -324,6 +324,15 @@ static int mdio_bus_phy_restore(struct device *dev) if (ret < 0) return ret; + if (phydev->drv->config_intr && phy_interrupt_is_valid(phydev)) + { + /* Some PHYs (e.g. SMSC LAN8720) clear their + * interrupt mask on software reset. + */ + phy_free_interrupt(phydev); + phy_request_interrupt(phydev); + } + if (phydev->attached_dev && phydev->adjust_link) phy_start_machine(phydev);
Some PHY (e.g. SMSC LAN87xx) clear their interrupt mask on software reset. This breaks the ethernet interface on resuming from hibernation, if the PHY is running in interrupt mode, so reconfigure interrupts after the software reset in mdio_bus_phy_restore(). Signed-off-by: Laurent Badel <laurentbadel@eaton.com> --- drivers/net/phy/phy_device.c | 9 +++++++++ 1 file changed, 9 insertions(+)