diff mbox series

[net-next] bonding: add TLS dependency

Message ID 20210125113209.2248522-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit 285715ac9a81209540bfdb2495e3a005b701bef8
Delegated to: Netdev Maintainers
Headers show
Series [net-next] bonding: add TLS dependency | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for net-next
netdev/subject_prefix success Link
netdev/cc_maintainers success CCed 3 of 3 maintainers
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success Link
netdev/stable success Stable not CCed

Commit Message

Arnd Bergmann Jan. 25, 2021, 11:31 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

When TLS is a module, the built-in bonding driver may cause a
link error:

x86_64-linux-ld: drivers/net/bonding/bond_main.o: in function `bond_start_xmit':
bond_main.c:(.text+0xc451): undefined reference to `tls_validate_xmit_skb'

Add a dependency to avoid the problem.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I could not figure out when this started, it seems to have been
possible for a while.
---
 drivers/net/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

patchwork-bot+netdevbpf@kernel.org Jan. 27, 2021, 1:50 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 25 Jan 2021 12:31:59 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> When TLS is a module, the built-in bonding driver may cause a
> link error:
> 
> x86_64-linux-ld: drivers/net/bonding/bond_main.o: in function `bond_start_xmit':
> bond_main.c:(.text+0xc451): undefined reference to `tls_validate_xmit_skb'
> 
> [...]

Here is the summary with links:
  - [net-next] bonding: add TLS dependency
    https://git.kernel.org/netdev/net-next/c/285715ac9a81

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 672fcdd9aecb..45d12b0e9a2f 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -42,6 +42,7 @@  config BONDING
 	tristate "Bonding driver support"
 	depends on INET
 	depends on IPV6 || IPV6=n
+	depends on TLS || TLS_DEVICE=n
 	help
 	  Say 'Y' or 'M' if you wish to be able to 'bond' multiple Ethernet
 	  Channels together. This is called 'Etherchannel' by Cisco,