diff mbox series

[net-next] ipa: add remoteproc dependency

Message ID 20210125113557.2388311-1-arnd@kernel.org (mailing list archive)
State Rejected
Delegated to: Netdev Maintainers
Headers show
Series [net-next] ipa: add remoteproc dependency | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for net-next
netdev/subject_prefix success Link
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success Link
netdev/stable success Stable not CCed

Commit Message

Arnd Bergmann Jan. 25, 2021, 11:35 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

Compile-testing without CONFIG_REMOTEPROC results in a build failure:

>>> referenced by ipa_main.c
>>>               net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
ld.lld: error: undefined symbol: rproc_put
>>> referenced by ipa_main.c
>>>               net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
>>> referenced by ipa_main.c
>>>               net/ipa/ipa_main.o:(ipa_remove) in archive drivers/built-in.a

Add a new dependency to avoid this.

Fixes: 38a4066f593c ("net: ipa: support COMPILE_TEST")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ipa/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Bjorn Andersson Jan. 25, 2021, 3:23 p.m. UTC | #1 
On Mon 25 Jan 05:35 CST 2021, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> Compile-testing without CONFIG_REMOTEPROC results in a build failure:
> 
> >>> referenced by ipa_main.c
> >>>               net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
> ld.lld: error: undefined symbol: rproc_put
> >>> referenced by ipa_main.c
> >>>               net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
> >>> referenced by ipa_main.c
> >>>               net/ipa/ipa_main.o:(ipa_remove) in archive drivers/built-in.a
> 
> Add a new dependency to avoid this.
> 

Afaict this should be addressed by:

86fdf1fc60e9 ("net: ipa: remove a remoteproc dependency")

which is present in linux-next.

Regards,
Bjorn

> Fixes: 38a4066f593c ("net: ipa: support COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/net/ipa/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig
> index b68f1289b89e..aa1c0ae3cf01 100644
> --- a/drivers/net/ipa/Kconfig
> +++ b/drivers/net/ipa/Kconfig
> @@ -3,6 +3,7 @@ config QCOM_IPA
>  	depends on 64BIT && NET && QCOM_SMEM
>  	depends on ARCH_QCOM || COMPILE_TEST
>  	depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST)
> +	depends on REMOTEPROC
>  	select QCOM_MDT_LOADER if ARCH_QCOM
>  	select QCOM_QMI_HELPERS
>  	help
> -- 
> 2.29.2
>
Arnd Bergmann Jan. 25, 2021, 3:30 p.m. UTC | #2 
On Mon, Jan 25, 2021 at 4:23 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Mon 25 Jan 05:35 CST 2021, Arnd Bergmann wrote:
>
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Compile-testing without CONFIG_REMOTEPROC results in a build failure:
> >
> > >>> referenced by ipa_main.c
> > >>>               net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
> > ld.lld: error: undefined symbol: rproc_put
> > >>> referenced by ipa_main.c
> > >>>               net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
> > >>> referenced by ipa_main.c
> > >>>               net/ipa/ipa_main.o:(ipa_remove) in archive drivers/built-in.a
> >
> > Add a new dependency to avoid this.
> >
>
> Afaict this should be addressed by:
>
> 86fdf1fc60e9 ("net: ipa: remove a remoteproc dependency")
>
> which is present in linux-next.

Ok, good. I was testing with next-20210122, which was
still lacking that commit.

      Arnd
Alex Elder Jan. 25, 2021, 3:33 p.m. UTC | #3 
On 1/25/21 9:30 AM, Arnd Bergmann wrote:
> On Mon, Jan 25, 2021 at 4:23 PM Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
>>
>> On Mon 25 Jan 05:35 CST 2021, Arnd Bergmann wrote:
>>
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> Compile-testing without CONFIG_REMOTEPROC results in a build failure:
>>>
>>>>>> referenced by ipa_main.c
>>>>>>                net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
>>> ld.lld: error: undefined symbol: rproc_put
>>>>>> referenced by ipa_main.c
>>>>>>                net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
>>>>>> referenced by ipa_main.c
>>>>>>                net/ipa/ipa_main.o:(ipa_remove) in archive drivers/built-in.a
>>>
>>> Add a new dependency to avoid this.
>>>
>>
>> Afaict this should be addressed by:
>>
>> 86fdf1fc60e9 ("net: ipa: remove a remoteproc dependency")
>>
>> which is present in linux-next.
> 
> Ok, good. I was testing with next-20210122, which was
> still lacking that commit.

Yes, for various reasons this took a while to get incorporated.
It just got accepted over the weekend.  Thanks for mentioning it.

					-Alex

> 
>        Arnd
>
diff mbox series

Patch

diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig
index b68f1289b89e..aa1c0ae3cf01 100644
--- a/drivers/net/ipa/Kconfig
+++ b/drivers/net/ipa/Kconfig
@@ -3,6 +3,7 @@  config QCOM_IPA
 	depends on 64BIT && NET && QCOM_SMEM
 	depends on ARCH_QCOM || COMPILE_TEST
 	depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST)
+	depends on REMOTEPROC
 	select QCOM_MDT_LOADER if ARCH_QCOM
 	select QCOM_QMI_HELPERS
 	help