| Message ID | 20210126232419.175836-2-saeedm@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,01/14] devlink: Add DMAC filter generic packet trap | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Pull request |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 3 maintainers not CCed: jiri@nvidia.com linux-doc@vger.kernel.org corbet@lwn.net |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 486 this patch: 486 |
| netdev/kdoc | success | Errors and warnings before: 16 this patch: 16 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 33 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 676 this patch: 676 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Tue, 26 Jan 2021 15:24:06 -0800 Saeed Mahameed wrote: > From: Aya Levin <ayal@nvidia.com> > > Add packet trap that can report packets that were dropped due to > destination MAC filtering. > > Signed-off-by: Aya Levin <ayal@nvidia.com> > Reviewed-by: Ido Schimmel <idosch@nvidia.com> > Reviewed-by: Moshe Shemesh <moshe@nvidia.com> > Reviewed-by: Tariq Toukan <tariqt@nvidia.com> > Signed-off-by: Tariq Toukan <tariqt@nvidia.com> > Signed-off-by: Saeed Mahameed <saeedm@nvidia.com> > --- > Documentation/networking/devlink/devlink-trap.rst | 5 +++++ > include/net/devlink.h | 3 +++ > net/core/devlink.c | 1 + > 3 files changed, 9 insertions(+) > > diff --git a/Documentation/networking/devlink/devlink-trap.rst b/Documentation/networking/devlink/devlink-trap.rst > index d875f3e1e9cf..1dd86976ecf8 100644 > --- a/Documentation/networking/devlink/devlink-trap.rst > +++ b/Documentation/networking/devlink/devlink-trap.rst > @@ -480,6 +480,11 @@ be added to the following table: > - ``drop`` > - Traps packets that the device decided to drop in case they hit a > blackhole nexthop > + * - ``dmac_filter`` > + - ``drop`` > + - Traps incoming packets that the device decided to drop in case s/in case/because/ > + the destination MAC is not configured in the MAC table ... and the interface is not in promiscuous mode > + Double new line > Driver-specific Packet Traps > ============================ Fix that up and applied from the list.
On Wed, 2021-01-27 at 19:54 -0800, Jakub Kicinski wrote: > On Tue, 26 Jan 2021 15:24:06 -0800 Saeed Mahameed wrote: > > From: Aya Levin <ayal@nvidia.com> > > > > Add packet trap that can report packets that were dropped due to > > destination MAC filtering. > > > > Signed-off-by: Aya Levin <ayal@nvidia.com> > > Reviewed-by: Ido Schimmel <idosch@nvidia.com> > > Reviewed-by: Moshe Shemesh <moshe@nvidia.com> > > Reviewed-by: Tariq Toukan <tariqt@nvidia.com> > > Signed-off-by: Tariq Toukan <tariqt@nvidia.com> > > Signed-off-by: Saeed Mahameed <saeedm@nvidia.com> > > --- > > Documentation/networking/devlink/devlink-trap.rst | 5 +++++ > > include/net/devlink.h | 3 +++ > > net/core/devlink.c | 1 + > > 3 files changed, 9 insertions(+) > > > > diff --git a/Documentation/networking/devlink/devlink-trap.rst > > b/Documentation/networking/devlink/devlink-trap.rst > > index d875f3e1e9cf..1dd86976ecf8 100644 > > --- a/Documentation/networking/devlink/devlink-trap.rst > > +++ b/Documentation/networking/devlink/devlink-trap.rst > > @@ -480,6 +480,11 @@ be added to the following table: > > - ``drop`` > > - Traps packets that the device decided to drop in case they > > hit a > > blackhole nexthop > > + * - ``dmac_filter`` > > + - ``drop`` > > + - Traps incoming packets that the device decided to drop in > > case > > s/in case/because/ > > > + the destination MAC is not configured in the MAC table > > ... and the interface is not in promiscuous mode > Makes sense ! > > + > > Double new line > > > Driver-specific Packet Traps > > ============================ > > Fix that up and applied from the list. Thanks, I can stop sending pull requests and siwtch to normal patchsets if this will be more convenient to you/ to me is just converting the cover letter :)..
On Thu, 28 Jan 2021 00:19:48 -0800 Saeed Mahameed wrote: > On Wed, 2021-01-27 at 19:54 -0800, Jakub Kicinski wrote: > > On Tue, 26 Jan 2021 15:24:06 -0800 Saeed Mahameed wrote: > > > From: Aya Levin <ayal@nvidia.com> > > > > > > Add packet trap that can report packets that were dropped due to > > > destination MAC filtering. > > > > > > Signed-off-by: Aya Levin <ayal@nvidia.com> > > > Reviewed-by: Ido Schimmel <idosch@nvidia.com> > > > Reviewed-by: Moshe Shemesh <moshe@nvidia.com> > > > Reviewed-by: Tariq Toukan <tariqt@nvidia.com> > > > Signed-off-by: Tariq Toukan <tariqt@nvidia.com> > > > Signed-off-by: Saeed Mahameed <saeedm@nvidia.com> > > > > s/in case/because/ > > > > > + the destination MAC is not configured in the MAC table > > > > ... and the interface is not in promiscuous mode > > > > Makes sense ! > > > > + > > > > Double new line > > > > > Driver-specific Packet Traps > > > ============================ > > > > Fix that up and applied from the list. > > Thanks, > I can stop sending pull requests and siwtch to normal patchsets > if this will be more convenient to you/ > > to me is just converting the cover letter :).. No preference on my side, as long as the patches are on the ML it's just the matter of remembering which parameters to pass to my scripts :)
diff --git a/Documentation/networking/devlink/devlink-trap.rst b/Documentation/networking/devlink/devlink-trap.rst index d875f3e1e9cf..1dd86976ecf8 100644 --- a/Documentation/networking/devlink/devlink-trap.rst +++ b/Documentation/networking/devlink/devlink-trap.rst @@ -480,6 +480,11 @@ be added to the following table: - ``drop`` - Traps packets that the device decided to drop in case they hit a blackhole nexthop + * - ``dmac_filter`` + - ``drop`` + - Traps incoming packets that the device decided to drop in case + the destination MAC is not configured in the MAC table + Driver-specific Packet Traps ============================ diff --git a/include/net/devlink.h b/include/net/devlink.h index d12ed2854c34..426b98e74b6e 100644 --- a/include/net/devlink.h +++ b/include/net/devlink.h @@ -838,6 +838,7 @@ enum devlink_trap_generic_id { DEVLINK_TRAP_GENERIC_ID_GTP_PARSING, DEVLINK_TRAP_GENERIC_ID_ESP_PARSING, DEVLINK_TRAP_GENERIC_ID_BLACKHOLE_NEXTHOP, + DEVLINK_TRAP_GENERIC_ID_DMAC_FILTER, /* Add new generic trap IDs above */ __DEVLINK_TRAP_GENERIC_ID_MAX, @@ -1063,6 +1064,8 @@ enum devlink_trap_group_generic_id { "esp_parsing" #define DEVLINK_TRAP_GENERIC_NAME_BLACKHOLE_NEXTHOP \ "blackhole_nexthop" +#define DEVLINK_TRAP_GENERIC_NAME_DMAC_FILTER \ + "dest_mac_filter" #define DEVLINK_TRAP_GROUP_GENERIC_NAME_L2_DROPS \ "l2_drops" diff --git a/net/core/devlink.c b/net/core/devlink.c index 72ea79879762..f6e6445b9801 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -9512,6 +9512,7 @@ static const struct devlink_trap devlink_trap_generic[] = { DEVLINK_TRAP(GTP_PARSING, DROP), DEVLINK_TRAP(ESP_PARSING, DROP), DEVLINK_TRAP(BLACKHOLE_NEXTHOP, DROP), + DEVLINK_TRAP(DMAC_FILTER, DROP), }; #define DEVLINK_TRAP_GROUP(_id) \