mbox

[pull,request,net,00/12] mlx5 fixes 2021-01-26

Message ID 20210126234345.202096-1-saeedm@nvidia.com (mailing list archive)
State Accepted
Delegated to: Netdev Maintainers
Headers show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git tags/mlx5-fixes-2021-01-26

Message

Saeed Mahameed Jan. 26, 2021, 11:43 p.m. UTC
Hi Jakub, Dave

This series introduces some fixes to mlx5 driver.
Please pull and let me know if there is any problem.

Thanks,
Saeed.

---
The following changes since commit c5e9e8d48acdf3b863282af7f6f6931d39526245:

  Merge tag 'mac80211-for-net-2021-01-26' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211 (2021-01-26 15:23:18 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git tags/mlx5-fixes-2021-01-26

for you to fetch changes up to e2194a1744e8594e82a861687808c1adca419b85:

  net/mlx5: CT: Fix incorrect removal of tuple_nat_node from nat rhashtable (2021-01-26 15:39:04 -0800)

----------------------------------------------------------------
mlx5-fixes-2021-01-26

----------------------------------------------------------------
Daniel Jurgens (1):
      net/mlx5: Maintain separate page trees for ECPF and PF functions

Maor Dickman (2):
      net/mlx5e: Reduce tc unsupported key print level
      net/mlx5e: Disable hw-tc-offload when MLX5_CLS_ACT config is disabled

Maxim Mikityanskiy (4):
      net/mlx5e: Fix IPSEC stats
      net/mlx5e: Correctly handle changing the number of queues when the interface is down
      net/mlx5e: Revert parameters on errors when changing trust state without reset
      net/mlx5e: Revert parameters on errors when changing MTU and LRO state without reset

Pan Bian (1):
      net/mlx5e: free page before return

Parav Pandit (1):
      net/mlx5e: E-switch, Fix rate calculation for overflow

Paul Blakey (2):
      net/mlx5e: Fix CT rule + encap slow path offload and deletion
      net/mlx5: CT: Fix incorrect removal of tuple_nat_node from nat rhashtable

Roi Dayan (1):
      net/mlx5: Fix memory leak on flow table creation error flow

 .../net/ethernet/mellanox/mlx5/core/en/health.c    |  2 +-
 drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 20 +++++---
 .../mellanox/mlx5/core/en_accel/ipsec_stats.c      |  4 +-
 drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 13 +++--
 .../net/ethernet/mellanox/mlx5/core/en_ethtool.c   |  8 ++-
 drivers/net/ethernet/mellanox/mlx5/core/en_main.c  | 39 +++++++++++----
 drivers/net/ethernet/mellanox/mlx5/core/en_rep.c   |  2 +
 drivers/net/ethernet/mellanox/mlx5/core/en_tc.c    | 22 ++++++--
 drivers/net/ethernet/mellanox/mlx5/core/fs_core.c  |  1 +
 .../net/ethernet/mellanox/mlx5/core/pagealloc.c    | 58 +++++++++++++---------
 10 files changed, 114 insertions(+), 55 deletions(-)

Comments

Willem de Bruijn Jan. 27, 2021, 8:03 p.m. UTC | #1
On Wed, Jan 27, 2021 at 2:36 AM Saeed Mahameed <saeedm@nvidia.com> wrote:
>
> Hi Jakub, Dave
>
> This series introduces some fixes to mlx5 driver.
> Please pull and let me know if there is any problem.
>
> Thanks,
> Saeed.
>
> ---
> The following changes since commit c5e9e8d48acdf3b863282af7f6f6931d39526245:
>
>   Merge tag 'mac80211-for-net-2021-01-26' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211 (2021-01-26 15:23:18 -0800)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git tags/mlx5-fixes-2021-01-26
>
> for you to fetch changes up to e2194a1744e8594e82a861687808c1adca419b85:
>
>   net/mlx5: CT: Fix incorrect removal of tuple_nat_node from nat rhashtable (2021-01-26 15:39:04 -0800)
>
> ----------------------------------------------------------------
> mlx5-fixes-2021-01-26
>
> ----------------------------------------------------------------
> Daniel Jurgens (1):
>       net/mlx5: Maintain separate page trees for ECPF and PF functions
>
> Maor Dickman (2):
>       net/mlx5e: Reduce tc unsupported key print level
>       net/mlx5e: Disable hw-tc-offload when MLX5_CLS_ACT config is disabled
>
> Maxim Mikityanskiy (4):
>       net/mlx5e: Fix IPSEC stats
>       net/mlx5e: Correctly handle changing the number of queues when the interface is down
>       net/mlx5e: Revert parameters on errors when changing trust state without reset
>       net/mlx5e: Revert parameters on errors when changing MTU and LRO state without reset
>
> Pan Bian (1):
>       net/mlx5e: free page before return
>
> Parav Pandit (1):
>       net/mlx5e: E-switch, Fix rate calculation for overflow
>
> Paul Blakey (2):
>       net/mlx5e: Fix CT rule + encap slow path offload and deletion
>       net/mlx5: CT: Fix incorrect removal of tuple_nat_node from nat rhashtable
>
> Roi Dayan (1):
>       net/mlx5: Fix memory leak on flow table creation error flow
>
>  .../net/ethernet/mellanox/mlx5/core/en/health.c    |  2 +-
>  drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 20 +++++---
>  .../mellanox/mlx5/core/en_accel/ipsec_stats.c      |  4 +-
>  drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 13 +++--
>  .../net/ethernet/mellanox/mlx5/core/en_ethtool.c   |  8 ++-
>  drivers/net/ethernet/mellanox/mlx5/core/en_main.c  | 39 +++++++++++----
>  drivers/net/ethernet/mellanox/mlx5/core/en_rep.c   |  2 +
>  drivers/net/ethernet/mellanox/mlx5/core/en_tc.c    | 22 ++++++--
>  drivers/net/ethernet/mellanox/mlx5/core/fs_core.c  |  1 +
>  .../net/ethernet/mellanox/mlx5/core/pagealloc.c    | 58 +++++++++++++---------
>  10 files changed, 114 insertions(+), 55 deletions(-)

For netdrv:

Acked-by: Willem de Bruijn <willemb@google.com>

I left a small comment in patch 11/12, but no need to change that.

In patch 12/12, the removal of branch if (entry->tuple_node.next) is
not entirely obvious to me, but based on the commit message I assume
that it was intentional. Pointing it out only in the unlikely case
that it wasn't.
Saeed Mahameed Jan. 27, 2021, 11:08 p.m. UTC | #2
On Wed, 2021-01-27 at 15:03 -0500, Willem de Bruijn wrote:
> On Wed, Jan 27, 2021 at 2:36 AM Saeed Mahameed <saeedm@nvidia.com>
> wrote:
> > 
> > Hi Jakub, Dave
> > 
> > This series introduces some fixes to mlx5 driver.
> > Please pull and let me know if there is any problem.
> > 
> > Thanks,
> > Saeed.
> > 
> > ---
> > The following changes since commit
> > c5e9e8d48acdf3b863282af7f6f6931d39526245:
> > 
> >   Merge tag 'mac80211-for-net-2021-01-26' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211 (2021-
> > 01-26 15:23:18 -0800)
> > 
> > are available in the Git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git
> > tags/mlx5-fixes-2021-01-26
> > 
> > for you to fetch changes up to
> > e2194a1744e8594e82a861687808c1adca419b85:
> > 
> >   net/mlx5: CT: Fix incorrect removal of tuple_nat_node from nat
> > rhashtable (2021-01-26 15:39:04 -0800)
> > 
> > ----------------------------------------------------------------
> > mlx5-fixes-2021-01-26
> > 
> > ----------------------------------------------------------------
> > Daniel Jurgens (1):
> >       net/mlx5: Maintain separate page trees for ECPF and PF
> > functions
> > 
> > Maor Dickman (2):
> >       net/mlx5e: Reduce tc unsupported key print level
> >       net/mlx5e: Disable hw-tc-offload when MLX5_CLS_ACT config is
> > disabled
> > 
> > Maxim Mikityanskiy (4):
> >       net/mlx5e: Fix IPSEC stats
> >       net/mlx5e: Correctly handle changing the number of queues
> > when the interface is down
> >       net/mlx5e: Revert parameters on errors when changing trust
> > state without reset
> >       net/mlx5e: Revert parameters on errors when changing MTU and
> > LRO state without reset
> > 
> > Pan Bian (1):
> >       net/mlx5e: free page before return
> > 
> > Parav Pandit (1):
> >       net/mlx5e: E-switch, Fix rate calculation for overflow
> > 
> > Paul Blakey (2):
> >       net/mlx5e: Fix CT rule + encap slow path offload and deletion
> >       net/mlx5: CT: Fix incorrect removal of tuple_nat_node from
> > nat rhashtable
> > 
> > Roi Dayan (1):
> >       net/mlx5: Fix memory leak on flow table creation error flow
> > 
> >  .../net/ethernet/mellanox/mlx5/core/en/health.c    |  2 +-
> >  drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 20 +++++---
> >  .../mellanox/mlx5/core/en_accel/ipsec_stats.c      |  4 +-
> >  drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 13 +++--
> >  .../net/ethernet/mellanox/mlx5/core/en_ethtool.c   |  8 ++-
> >  drivers/net/ethernet/mellanox/mlx5/core/en_main.c  | 39
> > +++++++++++----
> >  drivers/net/ethernet/mellanox/mlx5/core/en_rep.c   |  2 +
> >  drivers/net/ethernet/mellanox/mlx5/core/en_tc.c    | 22 ++++++--
> >  drivers/net/ethernet/mellanox/mlx5/core/fs_core.c  |  1 +
> >  .../net/ethernet/mellanox/mlx5/core/pagealloc.c    | 58
> > +++++++++++++---------
> >  10 files changed, 114 insertions(+), 55 deletions(-)
> 
> For netdrv:
> 
> Acked-by: Willem de Bruijn <willemb@google.com>
> 
> I left a small comment in patch 11/12, but no need to change that.
> 
> In patch 12/12, the removal of branch if (entry->tuple_node.next) is
> not entirely obvious to me, but based on the commit message I assume
> that it was intentional. Pointing it out only in the unlikely case
> that it wasn't.

it was intentional as the check was redundant. 

Thanks for the review!