diff mbox series

[Internal,review,stable,v5.4,1/2] ICMPv6: Add ICMPv6 Parameter Problem, code 3 definition

Message ID 20210129192741.117693-1-acj@cisco.com (mailing list archive)
State Superseded
Headers show
Series [Internal,review,stable,v5.4,1/2] ICMPv6: Add ICMPv6 Parameter Problem, code 3 definition | expand

Checks

Context Check Description
netdev/tree_selection success Guessing tree name failed - patch did not apply

Commit Message

Aviraj CJ Jan. 29, 2021, 7:27 p.m. UTC 
From: Hangbin Liu <liuhangbin@gmail.com>

commit b59e286be280fa3c2e94a0716ddcee6ba02bc8ba upstream.

Based on RFC7112, Section 6:

   IANA has added the following "Type 4 - Parameter Problem" message to
   the "Internet Control Message Protocol version 6 (ICMPv6) Parameters"
   registry:

      CODE     NAME/DESCRIPTION
       3       IPv6 First Fragment has incomplete IPv6 Header Chain

Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Aviraj CJ <acj@cisco.com>
---
 include/uapi/linux/icmpv6.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Greg Kroah-Hartman Jan. 30, 2021, 8:36 a.m. UTC | #1 
On Sat, Jan 30, 2021 at 12:57:40AM +0530, Aviraj CJ wrote:
> From: Hangbin Liu <liuhangbin@gmail.com>
> 
> commit b59e286be280fa3c2e94a0716ddcee6ba02bc8ba upstream.
> 
> Based on RFC7112, Section 6:
> 
>    IANA has added the following "Type 4 - Parameter Problem" message to
>    the "Internet Control Message Protocol version 6 (ICMPv6) Parameters"
>    registry:
> 
>       CODE     NAME/DESCRIPTION
>        3       IPv6 First Fragment has incomplete IPv6 Header Chain
> 
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Aviraj CJ <acj@cisco.com>
> ---
>  include/uapi/linux/icmpv6.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/linux/icmpv6.h b/include/uapi/linux/icmpv6.h
> index 2622b5a3e616..9a31ea2ad1cf 100644
> --- a/include/uapi/linux/icmpv6.h
> +++ b/include/uapi/linux/icmpv6.h
> @@ -137,6 +137,7 @@ struct icmp6hdr {
>  #define ICMPV6_HDR_FIELD		0
>  #define ICMPV6_UNK_NEXTHDR		1
>  #define ICMPV6_UNK_OPTION		2
> +#define ICMPV6_HDR_INCOMP		3
>  
>  /*
>   *	constants for (set|get)sockopt
> -- 
> 2.26.2.Cisco
> 

What do you mean by "internal review" and what am I supposed to do with
this patch?  Same for the 2/2 patch in this series...

thanks,

greg k-h
Aviraj CJ Jan. 30, 2021, 11:31 a.m. UTC | #2 
On 30/01/21, 2:06 PM, "Greg KH" <gregkh@linuxfoundation.org> wrote:

On Sat, Jan 30, 2021 at 12:57:40AM +0530, Aviraj CJ wrote:
> From: Hangbin Liu <liuhangbin@gmail.com>
> 
> commit b59e286be280fa3c2e94a0716ddcee6ba02bc8ba upstream.
> 
> Based on RFC7112, Section 6:
> 
>    IANA has added the following "Type 4 - Parameter Problem" message to
>    the "Internet Control Message Protocol version 6 (ICMPv6) Parameters"
>    registry:
> 
>       CODE     NAME/DESCRIPTION
>        3       IPv6 First Fragment has incomplete IPv6 Header Chain
> 
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Aviraj CJ <acj@cisco.com>
> ---
>  include/uapi/linux/icmpv6.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/linux/icmpv6.h b/include/uapi/linux/icmpv6.h
> index 2622b5a3e616..9a31ea2ad1cf 100644
> --- a/include/uapi/linux/icmpv6.h
> +++ b/include/uapi/linux/icmpv6.h
> @@ -137,6 +137,7 @@ struct icmp6hdr {
>  #define ICMPV6_HDR_FIELD		0
>  #define ICMPV6_UNK_NEXTHDR		1
>  #define ICMPV6_UNK_OPTION		2
> +#define ICMPV6_HDR_INCOMP		3
>  
>  /*
>   *	constants for (set|get)sockopt
> -- 
> 2.26.2.Cisco
> 

What do you mean by "internal review" and what am I supposed to do with
this patch?  Same for the 2/2 patch in this series...
<ACJ> Sorry " internal review" added by mistake, this is the correct patch for v5.4 branch, pls let me if u want me to send it by correcting...

thanks,

greg k-h
Greg Kroah-Hartman Jan. 30, 2021, 11:51 a.m. UTC | #3 
On Sat, Jan 30, 2021 at 11:31:11AM +0000, Aviraj Cj (acj) wrote:
> 
> 
> On 30/01/21, 2:06 PM, "Greg KH" <gregkh@linuxfoundation.org> wrote:
> 
> On Sat, Jan 30, 2021 at 12:57:40AM +0530, Aviraj CJ wrote:
> > From: Hangbin Liu <liuhangbin@gmail.com>
> > 
> > commit b59e286be280fa3c2e94a0716ddcee6ba02bc8ba upstream.
> > 
> > Based on RFC7112, Section 6:
> > 
> >    IANA has added the following "Type 4 - Parameter Problem" message to
> >    the "Internet Control Message Protocol version 6 (ICMPv6) Parameters"
> >    registry:
> > 
> >       CODE     NAME/DESCRIPTION
> >        3       IPv6 First Fragment has incomplete IPv6 Header Chain
> > 
> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > Signed-off-by: Aviraj CJ <acj@cisco.com>
> > ---
> >  include/uapi/linux/icmpv6.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/uapi/linux/icmpv6.h b/include/uapi/linux/icmpv6.h
> > index 2622b5a3e616..9a31ea2ad1cf 100644
> > --- a/include/uapi/linux/icmpv6.h
> > +++ b/include/uapi/linux/icmpv6.h
> > @@ -137,6 +137,7 @@ struct icmp6hdr {
> >  #define ICMPV6_HDR_FIELD		0
> >  #define ICMPV6_UNK_NEXTHDR		1
> >  #define ICMPV6_UNK_OPTION		2
> > +#define ICMPV6_HDR_INCOMP		3
> >  
> >  /*
> >   *	constants for (set|get)sockopt
> > -- 
> > 2.26.2.Cisco
> > 
> 
> What do you mean by "internal review" and what am I supposed to do with
> this patch?  Same for the 2/2 patch in this series...
> <ACJ> Sorry " internal review" added by mistake, this is the correct patch for v5.4 branch, pls let me if u want me to send it by correcting...

Please fix and resend.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/include/uapi/linux/icmpv6.h b/include/uapi/linux/icmpv6.h
index 2622b5a3e616..9a31ea2ad1cf 100644
--- a/include/uapi/linux/icmpv6.h
+++ b/include/uapi/linux/icmpv6.h
@@ -137,6 +137,7 @@  struct icmp6hdr {
 #define ICMPV6_HDR_FIELD		0
 #define ICMPV6_UNK_NEXTHDR		1
 #define ICMPV6_UNK_OPTION		2
+#define ICMPV6_HDR_INCOMP		3
 
 /*
  *	constants for (set|get)sockopt