| Message ID | 20210201232609.3524451-2-elder@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e6cdd6d80baedadb96d7060a509f51769e53021d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: ipa: a few bug fixes | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | fail | Series targets non-next tree, but doesn't contain any Fixes tags |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 4 of 4 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Mon, Feb 1, 2021 at 3:29 PM Alex Elder <elder@linaro.org> wrote: > > The virt local variable in gsi_channel_state() does not have an > __iomem attribute but should. Fix this. > > Signed-off-by: Alex Elder <elder@linaro.org> > --- > drivers/net/ipa/gsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c > index 14d9a791924bf..e2e77f09077a9 100644 > --- a/drivers/net/ipa/gsi.c > +++ b/drivers/net/ipa/gsi.c > @@ -440,7 +440,7 @@ static void gsi_evt_ring_de_alloc_command(struct gsi *gsi, u32 evt_ring_id) > static enum gsi_channel_state gsi_channel_state(struct gsi_channel *channel) > { > u32 channel_id = gsi_channel_id(channel); > - void *virt = channel->gsi->virt; > + void __iomem *virt = channel->gsi->virt; > u32 val; > > val = ioread32(virt + GSI_CH_C_CNTXT_0_OFFSET(channel_id)); > -- > 2.27.0 > Seems pretty straightforward to me, ioread32 expects an __iomem-annotated pointer. Reviewed-by: Amy Parker <enbyamy@gmail.com>
diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c index 14d9a791924bf..e2e77f09077a9 100644 --- a/drivers/net/ipa/gsi.c +++ b/drivers/net/ipa/gsi.c @@ -440,7 +440,7 @@ static void gsi_evt_ring_de_alloc_command(struct gsi *gsi, u32 evt_ring_id) static enum gsi_channel_state gsi_channel_state(struct gsi_channel *channel) { u32 channel_id = gsi_channel_id(channel); - void *virt = channel->gsi->virt; + void __iomem *virt = channel->gsi->virt; u32 val; val = ioread32(virt + GSI_CH_C_CNTXT_0_OFFSET(channel_id));
The virt local variable in gsi_channel_state() does not have an __iomem attribute but should. Fix this. Signed-off-by: Alex Elder <elder@linaro.org> --- drivers/net/ipa/gsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)