From patchwork Mon Feb 1 23:26:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 12060239 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F9B3C433E0 for ; Mon, 1 Feb 2021 23:27:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0397164E2E for ; Mon, 1 Feb 2021 23:27:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231321AbhBAX1N (ORCPT ); Mon, 1 Feb 2021 18:27:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231273AbhBAX04 (ORCPT ); Mon, 1 Feb 2021 18:26:56 -0500 Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1257C0613ED for ; Mon, 1 Feb 2021 15:26:15 -0800 (PST) Received: by mail-il1-x12d.google.com with SMTP id m20so9835949ilj.13 for ; Mon, 01 Feb 2021 15:26:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TZynBD22K6qpzM6Yh76qjCwf3pTBe5alSzNft0NWoIQ=; b=NIHr2Aq+gAUuQ+bMAHQM1WU4q2DPkL+sVGYZEN1OnIFVyZkBbEKCpftjUDCAqITBsf RP8hEazoRxKh7FvP1o8SlpNPTxBy6gLs6679bosgwNgpv3i8TTC3pooIAHKE9oKojkum cFBXvH1eCxC0DiPkT1VIanRe7sM5MHjxq4uDCF7NyZ2TSCxj2GM8yQ0txihq6/KXkJVx vxo3QpeG4kZdtFQwVEov7QMseUB2hOvrKJx+VPTTkee3n4r617mJMRxXTjRuXciwGb/P MGjISQq3R+SLUKimd2S7k71O0pQ7YLvrNC8DfxltWasAXrpVq0Xc/T2/OzlJLmBywZyM YdXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TZynBD22K6qpzM6Yh76qjCwf3pTBe5alSzNft0NWoIQ=; b=hiUlagVpiyMcvLMNv6dlADYHmz7yIjKDneNf0ymAcS9isY4CRbW6gdtyo2GjFOVefY dLJZIa0fI1LRNUUdCbI07iQ/rafARquKjdUDRZ1UmUOChyGg3VVQg2HzXAx1gcNUHqog 00iaK5wh4NC8XTysbyPrbNBYYHqK8Z+0650MayfRigfrRbohIQ30020N+4b6+esXCmlG Ju9tZbmqScVkMDVj0NEP0tYEFdcY+6hOttFVL/PD7El6a5E0BNyU1QfMpmRhv6Z9ezJ7 ci/UAZimGdGk+vJ39+Iy5llqYjOyoFQcyMMiysKttdjaOhVI0S3mhTCk+mIALhEXtvdR Giyg== X-Gm-Message-State: AOAM533aO9Qc3az56MSJm7UliJxi1yNTaQu3IGu/EurhSo9FLvsVypiL Iopz3+/YFHFcA7+5VdtpB5znkg== X-Google-Smtp-Source: ABdhPJyhNtu8B0+dY6bUUX9WUh982PLYELjLAMiQjTBfhhJZ0zRPvYd86WuP/bSXAB0+F8Ar43wDjQ== X-Received: by 2002:a05:6e02:1a89:: with SMTP id k9mr13620271ilv.68.1612221975432; Mon, 01 Feb 2021 15:26:15 -0800 (PST) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id v18sm10359588ila.29.2021.02.01.15.26.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 15:26:14 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: elder@kernel.org, evgreen@chromium.org, bjorn.andersson@linaro.org, cpratapa@codeaurora.org, subashab@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 2/4] net: ipa: be explicit about endianness Date: Mon, 1 Feb 2021 17:26:07 -0600 Message-Id: <20210201232609.3524451-3-elder@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210201232609.3524451-1-elder@linaro.org> References: <20210201232609.3524451-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Sparse warns that the assignment of the metadata mask for a QMAP endpoint in ipa_endpoint_init_hdr_metadata_mask() is a bad assignment. We know we want the mask value to be big endian, even though the value we write is in host byte order. Use a __force tag to indicate we really mean it. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_endpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 9f4be9812a1f3..448d89da1e456 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -588,7 +588,7 @@ static void ipa_endpoint_init_hdr_metadata_mask(struct ipa_endpoint *endpoint) /* Note that HDR_ENDIANNESS indicates big endian header fields */ if (endpoint->data->qmap) - val = cpu_to_be32(IPA_ENDPOINT_QMAP_METADATA_MASK); + val = (__force u32)cpu_to_be32(IPA_ENDPOINT_QMAP_METADATA_MASK); iowrite32(val, endpoint->ipa->reg_virt + offset); }