| Message ID | 20210202090304.2740471-1-ennoerlangen@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6c9f18f294c4a1a6d8b1097e39c325481664ee1c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v1] net: hsr: align sup_multicast_addr in struct hsr_priv to u16 boundary | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 4 maintainers not CCed: yuehaibing@huawei.com m-karicheri2@ti.com kuba@kernel.org ap420073@gmail.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | WARNING: line length of 82 exceeds 80 columns WARNING: line length of 84 exceeds 80 columns |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 2 Feb 2021 10:03:04 +0100 you wrote: > From: Andreas Oetken <andreas.oetken@siemens.com> > > sup_multicast_addr is passed to ether_addr_equal for address comparison > which casts the address inputs to u16 leading to an unaligned access. > Aligning the sup_multicast_addr to u16 boundary fixes the issue. > > Signed-off-by: Andreas Oetken <andreas.oetken@siemens.com> > > [...] Here is the summary with links: - [v1] net: hsr: align sup_multicast_addr in struct hsr_priv to u16 boundary https://git.kernel.org/netdev/net/c/6c9f18f294c4 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/hsr/hsr_main.h b/net/hsr/hsr_main.h index 7dc92ce5a134..a9c30a608e35 100644 --- a/net/hsr/hsr_main.h +++ b/net/hsr/hsr_main.h @@ -217,7 +217,10 @@ struct hsr_priv { u8 net_id; /* for PRP, it occupies most significant 3 bits * of lan_id */ - unsigned char sup_multicast_addr[ETH_ALEN]; + unsigned char sup_multicast_addr[ETH_ALEN] __aligned(sizeof(u16)); + /* Align to u16 boundary to avoid unaligned access + * in ether_addr_equal + */ #ifdef CONFIG_DEBUG_FS struct dentry *node_tbl_root; #endif