diff mbox series

[net-next] inet: do not export inet_gro_{receive|complete}

Message ID 20210202154145.1568451-1-eric.dumazet@gmail.com (mailing list archive)
State Accepted
Commit fca23f37f3a7f6296d1ae98606871fd7ed565a0b
Delegated to: Netdev Maintainers
Headers show
Series [net-next] inet: do not export inet_gro_{receive|complete} | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for net-next
netdev/subject_prefix success Link
netdev/cc_maintainers warning 2 maintainers not CCed: yoshfuji@linux-ipv6.org dsahern@kernel.org
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 2 this patch: 2
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 21 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 2 this patch: 2
netdev/header_inline success Link
netdev/stable success Stable not CCed

Commit Message

Eric Dumazet Feb. 2, 2021, 3:41 p.m. UTC 
From: Eric Dumazet <edumazet@google.com>

inet_gro_receive() and inet_gro_complete() are part
of GRO engine which can not be modular.

Similarly, inet_gso_segment() does not need to be exported,
being part of GSO stack.

In other words, net/ipv6/ip6_offload.o is part of vmlinux,
regardless of CONFIG_IPV6.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Leon Romanovsky <leonro@nvidia.com>
---
 net/ipv4/af_inet.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Leon Romanovsky Feb. 2, 2021, 4:01 p.m. UTC | #1 
On Tue, Feb 02, 2021 at 07:41:45AM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> inet_gro_receive() and inet_gro_complete() are part
> of GRO engine which can not be modular.
>
> Similarly, inet_gso_segment() does not need to be exported,
> being part of GSO stack.
>
> In other words, net/ipv6/ip6_offload.o is part of vmlinux,
> regardless of CONFIG_IPV6.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Leon Romanovsky <leonro@nvidia.com>
> ---
>  net/ipv4/af_inet.c | 3 ---
>  1 file changed, 3 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
patchwork-bot+netdevbpf@kernel.org Feb. 3, 2021, 3:10 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue,  2 Feb 2021 07:41:45 -0800 you wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> inet_gro_receive() and inet_gro_complete() are part
> of GRO engine which can not be modular.
> 
> Similarly, inet_gso_segment() does not need to be exported,
> being part of GSO stack.
> 
> [...]

Here is the summary with links:
  - [net-next] inet: do not export inet_gro_{receive|complete}
    https://git.kernel.org/netdev/net-next/c/fca23f37f3a7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index b94fa8eb831bf3b18917529ef6a9263edb968592..be43c8d95af56624c4deee30e5f737eacdb884c1 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1419,7 +1419,6 @@  struct sk_buff *inet_gso_segment(struct sk_buff *skb,
 out:
 	return segs;
 }
-EXPORT_SYMBOL(inet_gso_segment);
 
 static struct sk_buff *ipip_gso_segment(struct sk_buff *skb,
 					netdev_features_t features)
@@ -1550,7 +1549,6 @@  struct sk_buff *inet_gro_receive(struct list_head *head, struct sk_buff *skb)
 
 	return pp;
 }
-EXPORT_SYMBOL(inet_gro_receive);
 
 static struct sk_buff *ipip_gro_receive(struct list_head *head,
 					struct sk_buff *skb)
@@ -1636,7 +1634,6 @@  int inet_gro_complete(struct sk_buff *skb, int nhoff)
 
 	return err;
 }
-EXPORT_SYMBOL(inet_gro_complete);
 
 static int ipip_gro_complete(struct sk_buff *skb, int nhoff)
 {