| Message ID | 20210204011821.18356-1-unixbhaskar@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [V2] drivers: net: ethernet: i825xx: Fix couple of spellings and get rid of blank lines too in the file ether1.c | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply |
On 2/3/21 5:18 PM, Bhaskar Chowdhury wrote: > > s/initialsation/initialisation/ > s/specifiing/specifying/ > > Plus get rid of few blank lines. > > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com> > --- > Changes from V1: > Fix typo in the subject line > Give explanation of all the changes in changelog text > > drivers/net/ethernet/i825xx/ether1.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c > index a0bfb509e002..850ea32091ed 100644 > --- a/drivers/net/ethernet/i825xx/ether1.c > +++ b/drivers/net/ethernet/i825xx/ether1.c a. don't delete the blank lines b. the change below is not described and does not change any whitespace AFAICT. I.e., DDT [don't do that]. > @@ -1047,7 +1044,7 @@ static void ether1_remove(struct expansion_card *ec) > { > struct net_device *dev = ecard_get_drvdata(ec); > > - ecard_set_drvdata(ec, NULL); > + ecard_set_drvdata(ec, NULL); > > unregister_netdev(dev); > free_netdev(dev);
On 18:09 Wed 03 Feb 2021, Randy Dunlap wrote: >On 2/3/21 5:18 PM, Bhaskar Chowdhury wrote: >> >> s/initialsation/initialisation/ >> s/specifiing/specifying/ >> >> Plus get rid of few blank lines. >> >> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com> >> --- >> Changes from V1: >> Fix typo in the subject line >> Give explanation of all the changes in changelog text >> >> drivers/net/ethernet/i825xx/ether1.c | 9 +++------ >> 1 file changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c >> index a0bfb509e002..850ea32091ed 100644 >> --- a/drivers/net/ethernet/i825xx/ether1.c >> +++ b/drivers/net/ethernet/i825xx/ether1.c > >a. don't delete the blank lines >b. the change below is not described and does not change any whitespace AFAICT. > I.e., DDT [don't do that]. > But what do you do when things getting automatically inducted in the patch???(You got to believe me) I haven't had touch that bloody function with my keystroke and it gets it on its own! Bemusing! Those blank lines too inducted from the fresh file(means in pristine form) ,so thought pruning would be good..hence the decision to get rid of those. Wondering what the fuck is going on.... >> @@ -1047,7 +1044,7 @@ static void ether1_remove(struct expansion_card *ec) >> { >> struct net_device *dev = ecard_get_drvdata(ec); >> >> - ecard_set_drvdata(ec, NULL); >> + ecard_set_drvdata(ec, NULL); >> >> unregister_netdev(dev); >> free_netdev(dev); > > >-- >~Randy >
On 2/3/21 6:32 PM, Bhaskar Chowdhury wrote: > On 18:09 Wed 03 Feb 2021, Randy Dunlap wrote: >> On 2/3/21 5:18 PM, Bhaskar Chowdhury wrote: >>> >>> s/initialsation/initialisation/ >>> s/specifiing/specifying/ >>> >>> Plus get rid of few blank lines. >>> >>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com> >>> --- >>> Changes from V1: >>> Fix typo in the subject line >>> Give explanation of all the changes in changelog text >>> >>> drivers/net/ethernet/i825xx/ether1.c | 9 +++------ >>> 1 file changed, 3 insertions(+), 6 deletions(-) >>> >>> diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c >>> index a0bfb509e002..850ea32091ed 100644 >>> --- a/drivers/net/ethernet/i825xx/ether1.c >>> +++ b/drivers/net/ethernet/i825xx/ether1.c >> >> a. don't delete the blank lines >> b. the change below is not described and does not change any whitespace AFAICT. >> I.e., DDT [don't do that]. >> > But what do you do when things getting automatically inducted in the > patch???(You got to believe me) > > I haven't had touch that bloody function with my keystroke and it gets it on > its own! Bemusing! > > Those blank lines too inducted from the fresh file(means in pristine form) ,so > thought pruning would be good..hence the decision to get rid of those. > > Wondering what the fuck is going on.... Yeah, it seems like you have had editor-doing-too-much-for-you issues before now...
diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c index a0bfb509e002..850ea32091ed 100644 --- a/drivers/net/ethernet/i825xx/ether1.c +++ b/drivers/net/ethernet/i825xx/ether1.c @@ -20,7 +20,7 @@ * 1.02 RMK 25/05/1997 Added code to restart RU if it goes not ready * 1.03 RMK 14/09/1997 Cleaned up the handling of a reset during the TX interrupt. * Should prevent lockup. - * 1.04 RMK 17/09/1997 Added more info when initialsation of chip goes wrong. + * 1.04 RMK 17/09/1997 Added more info when initialisation of chip goes wrong. * TDR now only reports failure when chip reports non-zero * TDR time-distance. * 1.05 RMK 31/12/1997 Removed calls to dev_tint for 2.1 @@ -117,7 +117,7 @@ ether1_outw_p (struct net_device *dev, unsigned short val, int addr, int svflgs) * Some inline assembler to allow fast transfers on to/off of the card. * Since this driver depends on some features presented by the ARM * specific architecture, and that you can't configure this driver - * without specifiing ARM mode, this is not a problem. + * without specifying ARM mode, this is not a problem. * * This routine is essentially an optimised memcpy from the card's * onboard RAM to kernel memory. @@ -885,7 +885,6 @@ ether1_recv_done (struct net_device *dev) ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_command, NORMALIRQS); ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_status, NORMALIRQS); ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_rbdoffset, NORMALIRQS); - priv(dev)->rx_tail = nexttail; priv(dev)->rx_head = ether1_readw(dev, priv(dev)->rx_head, rfd_t, rfd_link, NORMALIRQS); } while (1); @@ -1028,10 +1027,8 @@ ether1_probe(struct expansion_card *ec, const struct ecard_id *id) ret = register_netdev(dev); if (ret) goto free; - printk(KERN_INFO "%s: ether1 in slot %d, %pM\n", dev->name, ec->slot_no, dev->dev_addr); - ecard_set_drvdata(ec, dev); return 0; @@ -1047,7 +1044,7 @@ static void ether1_remove(struct expansion_card *ec) { struct net_device *dev = ecard_get_drvdata(ec); - ecard_set_drvdata(ec, NULL); + ecard_set_drvdata(ec, NULL); unregister_netdev(dev); free_netdev(dev);
s/initialsation/initialisation/ s/specifiing/specifying/ Plus get rid of few blank lines. Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com> --- Changes from V1: Fix typo in the subject line Give explanation of all the changes in changelog text drivers/net/ethernet/i825xx/ether1.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) -- 2.26.2