| Message ID | 20210204030639.14965-1-zhengyongjun3@huawei.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: core: Remove extra spaces | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 8 maintainers not CCed: chinagar@codeaurora.org lirongqing@baidu.com weichen.chen@linux.alibaba.com liuhangbin@gmail.com nikolay@cumulusnetworks.com mrv@mojatatu.com roopa@cumulusnetworks.com dsahern@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 3 this patch: 3 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 3 this patch: 3 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Thu, 4 Feb 2021 11:06:39 +0800 Zheng Yongjun wrote: > Do codingstyle clean up to remove extra spaces. > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> > --- > net/core/neighbour.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/neighbour.c b/net/core/neighbour.c > index 9500d28a43b0..72ea94ec8c4a 100644 > --- a/net/core/neighbour.c > +++ b/net/core/neighbour.c > @@ -1618,7 +1618,7 @@ struct neigh_parms *neigh_parms_alloc(struct net_device *dev, > > p = kmemdup(&tbl->parms, sizeof(*p), GFP_KERNEL); > if (p) { > - p->tbl = tbl; > + p->tbl = tbl; > refcount_set(&p->refcnt, 1); > p->reachable_time = ^ It's aligned with the assignment to reachable_time. I don't find this particularly offensive, there are worse style issues in this function. > neigh_rand_reach_time(NEIGH_VAR(p, BASE_REACHABLE_TIME));
Thank you, I will do this code style cleanup in ` net/core/neighbour.c` to fix the worse style issues you said :) -----邮件原件----- 发件人: Jakub Kicinski [mailto:kuba@kernel.org] 发送时间: 2021年2月5日 11:05 收件人: zhengyongjun <zhengyongjun3@huawei.com> 抄送: davem@davemloft.net; netdev@vger.kernel.org; linux-kernel@vger.kernel.org 主题: Re: [PATCH net-next] net: core: Remove extra spaces On Thu, 4 Feb 2021 11:06:39 +0800 Zheng Yongjun wrote: > Do codingstyle clean up to remove extra spaces. > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> > --- > net/core/neighbour.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/neighbour.c b/net/core/neighbour.c index > 9500d28a43b0..72ea94ec8c4a 100644 > --- a/net/core/neighbour.c > +++ b/net/core/neighbour.c > @@ -1618,7 +1618,7 @@ struct neigh_parms *neigh_parms_alloc(struct > net_device *dev, > > p = kmemdup(&tbl->parms, sizeof(*p), GFP_KERNEL); > if (p) { > - p->tbl = tbl; > + p->tbl = tbl; > refcount_set(&p->refcnt, 1); > p->reachable_time = ^ It's aligned with the assignment to reachable_time. I don't find this particularly offensive, there are worse style issues in this function. > neigh_rand_reach_time(NEIGH_VAR(p, BASE_REACHABLE_TIME));
diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 9500d28a43b0..72ea94ec8c4a 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -1618,7 +1618,7 @@ struct neigh_parms *neigh_parms_alloc(struct net_device *dev, p = kmemdup(&tbl->parms, sizeof(*p), GFP_KERNEL); if (p) { - p->tbl = tbl; + p->tbl = tbl; refcount_set(&p->refcnt, 1); p->reachable_time = neigh_rand_reach_time(NEIGH_VAR(p, BASE_REACHABLE_TIME));
Do codingstyle clean up to remove extra spaces. Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> --- net/core/neighbour.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)