| Message ID | 20210212201630.9003-1-drt@linux.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a6f2fe5f108c11ff8023d07f9c00cc3c9c3203b8 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,V2] ibmvnic: change IBMVNIC_MAX_IND_DESCS to 16 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 7 maintainers not CCed: linuxppc-dev@lists.ozlabs.org mpe@ellerman.id.au davem@davemloft.net tlfalcon@linux.ibm.com paulus@samba.org benh@kernel.crashing.org kuba@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 12 Feb 2021 15:16:30 -0500 you wrote: > The supported indirect subcrq entries on Power8 is 16. Power9 > supports 128. Redefined this value to 16 to minimize the driver from > having to reset when migrating between Power9 and Power8. In our rx/tx > performance testing, we found no performance difference between 16 and > 128 at this time. > > Fixes: f019fb6392e5 ("ibmvnic: Introduce indirect subordinate Command Response Queue buffer") > Signed-off-by: Dany Madden <drt@linux.ibm.com> > > [...] Here is the summary with links: - [net,V2] ibmvnic: change IBMVNIC_MAX_IND_DESCS to 16 https://git.kernel.org/netdev/net/c/a6f2fe5f108c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/ibm/ibmvnic.h b/drivers/net/ethernet/ibm/ibmvnic.h index c09c3f6bba9f..07ced1016aa4 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.h +++ b/drivers/net/ethernet/ibm/ibmvnic.h @@ -31,7 +31,7 @@ #define IBMVNIC_BUFFS_PER_POOL 100 #define IBMVNIC_MAX_QUEUES 16 #define IBMVNIC_MAX_QUEUE_SZ 4096 -#define IBMVNIC_MAX_IND_DESCS 128 +#define IBMVNIC_MAX_IND_DESCS 16 #define IBMVNIC_IND_ARR_SZ (IBMVNIC_MAX_IND_DESCS * 32) #define IBMVNIC_TSO_BUF_SZ 65536
The supported indirect subcrq entries on Power8 is 16. Power9 supports 128. Redefined this value to 16 to minimize the driver from having to reset when migrating between Power9 and Power8. In our rx/tx performance testing, we found no performance difference between 16 and 128 at this time. Fixes: f019fb6392e5 ("ibmvnic: Introduce indirect subordinate Command Response Queue buffer") Signed-off-by: Dany Madden <drt@linux.ibm.com> --- Changelog[V2]: Fixed fixes tag. Removed an extra s at the end of buffer. --- drivers/net/ethernet/ibm/ibmvnic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)