| Message ID | 20210216094012.183420-1-ducheng2@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4] staging: qlge: fix comment style in qlge_main.c | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Tue, Feb 16, 2021 at 05:40:12PM +0800, Du Cheng wrote: > align * in block comments on each line That says _what_ you did, not _why_ you did it. And "each line"? You only did this once. > This series of patches is for Task 10 of the Eudyptula Challenge This isn't a "series" of patches, it is a single patch. And no one cares about why you are doing this, this text isn't needed at all. thanks, greg k-h
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index 5516be3af898..2682a0e474bd 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c @@ -3815,8 +3815,7 @@ static int qlge_adapter_down(struct qlge_adapter *qdev) qlge_tx_ring_clean(qdev); - /* Call netif_napi_del() from common point. - */ + /* Call netif_napi_del() from common point. */ for (i = 0; i < qdev->rss_ring_count; i++) netif_napi_del(&qdev->rx_ring[i].napi);
align * in block comments on each line This series of patches is for Task 10 of the Eudyptula Challenge Signed-off-by: Du Cheng <ducheng2@gmail.com> --- changes v4: - move "changes" after triple-tiret changes v3: - add SUBSYSTEM in subject line - add explanation to past version of this patch changes v2: - move closing of comment to the same line changes v1: - align * in block comments drivers/staging/qlge/qlge_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)