| Message ID | 20210218182106.22613-1-camelia.groza@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 433dfc99aa3e0acbf655b961d98eb690162f758f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] dpaa_eth: fix the access method for the dpaa_napi_portal | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | fail | 2 blamed authors not CCed: madalin.bucur@nxp.com maciej.fijalkowski@intel.com; 2 maintainers not CCed: madalin.bucur@nxp.com maciej.fijalkowski@intel.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 14 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
> -----Original Message----- > From: Camelia Alexandra Groza <camelia.groza@nxp.com> > Sent: 18 February 2021 20:21 > To: kuba@kernel.org; davem@davemloft.net; s.hauer@pengutronix.de > Cc: brouer@redhat.com; Madalin Bucur (OSS) <madalin.bucur@oss.nxp.com>; > netdev@vger.kernel.org; Camelia Alexandra Groza <camelia.groza@nxp.com> > Subject: [PATCH net] dpaa_eth: fix the access method for the > dpaa_napi_portal > > The current use of container_of is flawed and unnecessary. Obtain > the dpaa_napi_portal reference from the private percpu data instead. > > Fixes: a1e031ffb422 ("dpaa_eth: add XDP_REDIRECT support") > Reported-by: Sascha Hauer <s.hauer@pengutronix.de> > Signed-off-by: Camelia Groza <camelia.groza@nxp.com> > --- > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > index 6faa20bed488..9905caeaeee3 100644 > --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > @@ -2672,7 +2672,6 @@ static enum qman_cb_dqrr_result > rx_default_dqrr(struct qman_portal *portal, > u32 hash; > u64 ns; > > - np = container_of(&portal, struct dpaa_napi_portal, p); > dpaa_fq = container_of(fq, struct dpaa_fq, fq_base); > fd_status = be32_to_cpu(fd->status); > fd_format = qm_fd_get_format(fd); > @@ -2687,6 +2686,7 @@ static enum qman_cb_dqrr_result > rx_default_dqrr(struct qman_portal *portal, > > percpu_priv = this_cpu_ptr(priv->percpu_priv); > percpu_stats = &percpu_priv->stats; > + np = &percpu_priv->np; > > if (unlikely(dpaa_eth_napi_schedule(percpu_priv, portal, > sched_napi))) > return qman_cb_dqrr_stop; > -- > 2.17.1 Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
On Thu, 18 Feb 2021 20:21:06 +0200 Camelia Groza <camelia.groza@nxp.com> wrote: > The current use of container_of is flawed and unnecessary. Obtain > the dpaa_napi_portal reference from the private percpu data instead. > > Fixes: a1e031ffb422 ("dpaa_eth: add XDP_REDIRECT support") > Reported-by: Sascha Hauer <s.hauer@pengutronix.de> > Signed-off-by: Camelia Groza <camelia.groza@nxp.com> > --- > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 18 Feb 2021 20:21:06 +0200 you wrote: > The current use of container_of is flawed and unnecessary. Obtain > the dpaa_napi_portal reference from the private percpu data instead. > > Fixes: a1e031ffb422 ("dpaa_eth: add XDP_REDIRECT support") > Reported-by: Sascha Hauer <s.hauer@pengutronix.de> > Signed-off-by: Camelia Groza <camelia.groza@nxp.com> > > [...] Here is the summary with links: - [net] dpaa_eth: fix the access method for the dpaa_napi_portal https://git.kernel.org/netdev/net/c/433dfc99aa3e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 6faa20bed488..9905caeaeee3 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -2672,7 +2672,6 @@ static enum qman_cb_dqrr_result rx_default_dqrr(struct qman_portal *portal, u32 hash; u64 ns; - np = container_of(&portal, struct dpaa_napi_portal, p); dpaa_fq = container_of(fq, struct dpaa_fq, fq_base); fd_status = be32_to_cpu(fd->status); fd_format = qm_fd_get_format(fd); @@ -2687,6 +2686,7 @@ static enum qman_cb_dqrr_result rx_default_dqrr(struct qman_portal *portal, percpu_priv = this_cpu_ptr(priv->percpu_priv); percpu_stats = &percpu_priv->stats; + np = &percpu_priv->np; if (unlikely(dpaa_eth_napi_schedule(percpu_priv, portal, sched_napi))) return qman_cb_dqrr_stop;
The current use of container_of is flawed and unnecessary. Obtain the dpaa_napi_portal reference from the private percpu data instead. Fixes: a1e031ffb422 ("dpaa_eth: add XDP_REDIRECT support") Reported-by: Sascha Hauer <s.hauer@pengutronix.de> Signed-off-by: Camelia Groza <camelia.groza@nxp.com> --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)