| Message ID | 20210221143559.390277-1-hslester96@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8eb65fda4a6dbd59cd5de24b106a10b6ee0d2176 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net/mlx4_core: Add missed mlx4_free_cmd_mailbox() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 8 of 8 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On 2/21/2021 4:35 PM, Chuhong Yuan wrote: > mlx4_do_mirror_rule() forgets to call mlx4_free_cmd_mailbox() to > free the memory region allocated by mlx4_alloc_cmd_mailbox() before > an exit. > Add the missed call to fix it. > > Fixes: 78efed275117 ("net/mlx4_core: Support mirroring VF DMFS rules on both ports") > Signed-off-by: Chuhong Yuan <hslester96@gmail.com> > --- > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c > index 394f43add85c..a99e71bc7b3c 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c > +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c > @@ -4986,6 +4986,7 @@ static int mlx4_do_mirror_rule(struct mlx4_dev *dev, struct res_fs_rule *fs_rule > > if (!fs_rule->mirr_mbox) { > mlx4_err(dev, "rule mirroring mailbox is null\n"); > + mlx4_free_cmd_mailbox(dev, mailbox); > return -EINVAL; > } > memcpy(mailbox->buf, fs_rule->mirr_mbox, fs_rule->mirr_mbox_size); > Reviewed-by: Tariq Toukan <tariqt@nvidia.com> Thanks for your patch. Tariq
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 21 Feb 2021 22:35:59 +0800 you wrote: > mlx4_do_mirror_rule() forgets to call mlx4_free_cmd_mailbox() to > free the memory region allocated by mlx4_alloc_cmd_mailbox() before > an exit. > Add the missed call to fix it. > > Fixes: 78efed275117 ("net/mlx4_core: Support mirroring VF DMFS rules on both ports") > Signed-off-by: Chuhong Yuan <hslester96@gmail.com> > > [...] Here is the summary with links: - net/mlx4_core: Add missed mlx4_free_cmd_mailbox() https://git.kernel.org/netdev/net/c/8eb65fda4a6d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c index 394f43add85c..a99e71bc7b3c 100644 --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c @@ -4986,6 +4986,7 @@ static int mlx4_do_mirror_rule(struct mlx4_dev *dev, struct res_fs_rule *fs_rule if (!fs_rule->mirr_mbox) { mlx4_err(dev, "rule mirroring mailbox is null\n"); + mlx4_free_cmd_mailbox(dev, mailbox); return -EINVAL; } memcpy(mailbox->buf, fs_rule->mirr_mbox, fs_rule->mirr_mbox_size);
mlx4_do_mirror_rule() forgets to call mlx4_free_cmd_mailbox() to free the memory region allocated by mlx4_alloc_cmd_mailbox() before an exit. Add the missed call to fix it. Fixes: 78efed275117 ("net/mlx4_core: Support mirroring VF DMFS rules on both ports") Signed-off-by: Chuhong Yuan <hslester96@gmail.com> --- drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 1 + 1 file changed, 1 insertion(+)