| Message ID | 20210224130356.51444-1-zhangkun4jr@163.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ath9k:remove unneeded variable in ath9k_dump_legacy_btcoex | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
zhangkun4jr@163.com wrote: > From: Zhang Kun <zhangkun@cdjrlc.com> > > Remove unneeded variable 'len' in ath9k_dump_legacy_btcoex. > > Signed-off-by: Zhang Kun <zhangkun@cdjrlc.com> This fails to compile. Always build check your patches! In file included from drivers/net/wireless/ath/ath9k/gpio.c:17: drivers/net/wireless/ath/ath9k/gpio.c: In function 'ath9k_dump_legacy_btcoex': drivers/net/wireless/ath/ath9k/ath9k.h:763:3: error: 'len' undeclared (first use in this function) 763 | len += scnprintf(buf + len, size - len, \ | ^~~ drivers/net/wireless/ath/ath9k/gpio.c:501:2: note: in expansion of macro 'ATH_DUMP_BTCOEX' 501 | ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type); | ^~~~~~~~~~~~~~~ drivers/net/wireless/ath/ath9k/ath9k.h:763:3: note: each undeclared identifier is reported only once for each function it appears in 763 | len += scnprintf(buf + len, size - len, \ | ^~~ drivers/net/wireless/ath/ath9k/gpio.c:501:2: note: in expansion of macro 'ATH_DUMP_BTCOEX' 501 | ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type); | ^~~~~~~~~~~~~~~ make[5]: *** [drivers/net/wireless/ath/ath9k/gpio.o] Error 1 make[4]: *** [drivers/net/wireless/ath/ath9k] Error 2 make[3]: *** [drivers/net/wireless/ath] Error 2 make[2]: *** [drivers/net/wireless] Error 2 make[1]: *** [drivers/net] Error 2 make: *** [drivers] Error 2 Patch set to Changes Requested.
diff --git a/drivers/net/wireless/ath/ath9k/gpio.c b/drivers/net/wireless/ath/ath9k/gpio.c index b457e52dd365..09ec937024c0 100644 --- a/drivers/net/wireless/ath/ath9k/gpio.c +++ b/drivers/net/wireless/ath/ath9k/gpio.c @@ -496,16 +496,14 @@ static int ath9k_dump_mci_btcoex(struct ath_softc *sc, u8 *buf, u32 size) static int ath9k_dump_legacy_btcoex(struct ath_softc *sc, u8 *buf, u32 size) { - struct ath_btcoex *btcoex = &sc->btcoex; - u32 len = 0; ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type); ATH_DUMP_BTCOEX("BTCoex Period (msec)", btcoex->btcoex_period); ATH_DUMP_BTCOEX("Duty Cycle", btcoex->duty_cycle); ATH_DUMP_BTCOEX("BT Wait time", btcoex->bt_wait_time); - return len; + return 0; } int ath9k_dump_btcoex(struct ath_softc *sc, u8 *buf, u32 size)