| Message ID | 20210305090205.GA139036@embeddedor (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [RESEND,next] ipv4: Fix fall-through warnings for Clang | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 3 maintainers not CCed: clang-built-linux@googlegroups.com ndesaulniers@google.com nathan@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 1 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 35 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1 this patch: 1 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:02, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of just > letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > net/ipv4/ah4.c | 1 + > net/ipv4/esp4.c | 1 + > net/ipv4/fib_semantics.c | 1 + > net/ipv4/ip_vti.c | 1 + > net/ipv4/ipcomp.c | 1 + > 5 files changed, 5 insertions(+) > > diff --git a/net/ipv4/ah4.c b/net/ipv4/ah4.c > index 36ed85bf2ad5..fab0958c41be 100644 > --- a/net/ipv4/ah4.c > +++ b/net/ipv4/ah4.c > @@ -450,6 +450,7 @@ static int ah4_err(struct sk_buff *skb, u32 info) > case ICMP_DEST_UNREACH: > if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED) > return 0; > + break; > case ICMP_REDIRECT: > break; > default: > diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c > index 4b834bbf95e0..6cb3ecad04b8 100644 > --- a/net/ipv4/esp4.c > +++ b/net/ipv4/esp4.c > @@ -982,6 +982,7 @@ static int esp4_err(struct sk_buff *skb, u32 info) > case ICMP_DEST_UNREACH: > if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED) > return 0; > + break; > case ICMP_REDIRECT: > break; > default: > diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c > index a632b66bc13a..4c0c33e4710d 100644 > --- a/net/ipv4/fib_semantics.c > +++ b/net/ipv4/fib_semantics.c > @@ -1874,6 +1874,7 @@ static int call_fib_nh_notifiers(struct fib_nh *nh, > (nh->fib_nh_flags & RTNH_F_DEAD)) > return call_fib4_notifiers(dev_net(nh->fib_nh_dev), > event_type, &info.info); > + break; > default: > break; > } > diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c > index 31c6c6d99d5e..eb560eecee08 100644 > --- a/net/ipv4/ip_vti.c > +++ b/net/ipv4/ip_vti.c > @@ -351,6 +351,7 @@ static int vti4_err(struct sk_buff *skb, u32 info) > case ICMP_DEST_UNREACH: > if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED) > return 0; > + break; > case ICMP_REDIRECT: > break; > default: > diff --git a/net/ipv4/ipcomp.c b/net/ipv4/ipcomp.c > index b42683212c65..bbb56f5e06dd 100644 > --- a/net/ipv4/ipcomp.c > +++ b/net/ipv4/ipcomp.c > @@ -31,6 +31,7 @@ static int ipcomp4_err(struct sk_buff *skb, u32 info) > case ICMP_DEST_UNREACH: > if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED) > return 0; > + break; > case ICMP_REDIRECT: > break; > default: >
Hi, I'm taking this in my -next[1] branch for v5.14. Thanks -- Gustavo [1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp On 4/20/21 15:05, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? > > Thanks > -- > Gustavo > > On 3/5/21 03:02, Gustavo A. R. Silva wrote: >> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple >> warnings by explicitly adding multiple break statements instead of just >> letting the code fall through to the next case. >> >> Link: https://github.com/KSPP/linux/issues/115 >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >> --- >> net/ipv4/ah4.c | 1 + >> net/ipv4/esp4.c | 1 + >> net/ipv4/fib_semantics.c | 1 + >> net/ipv4/ip_vti.c | 1 + >> net/ipv4/ipcomp.c | 1 + >> 5 files changed, 5 insertions(+) >> >> diff --git a/net/ipv4/ah4.c b/net/ipv4/ah4.c >> index 36ed85bf2ad5..fab0958c41be 100644 >> --- a/net/ipv4/ah4.c >> +++ b/net/ipv4/ah4.c >> @@ -450,6 +450,7 @@ static int ah4_err(struct sk_buff *skb, u32 info) >> case ICMP_DEST_UNREACH: >> if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED) >> return 0; >> + break; >> case ICMP_REDIRECT: >> break; >> default: >> diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c >> index 4b834bbf95e0..6cb3ecad04b8 100644 >> --- a/net/ipv4/esp4.c >> +++ b/net/ipv4/esp4.c >> @@ -982,6 +982,7 @@ static int esp4_err(struct sk_buff *skb, u32 info) >> case ICMP_DEST_UNREACH: >> if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED) >> return 0; >> + break; >> case ICMP_REDIRECT: >> break; >> default: >> diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c >> index a632b66bc13a..4c0c33e4710d 100644 >> --- a/net/ipv4/fib_semantics.c >> +++ b/net/ipv4/fib_semantics.c >> @@ -1874,6 +1874,7 @@ static int call_fib_nh_notifiers(struct fib_nh *nh, >> (nh->fib_nh_flags & RTNH_F_DEAD)) >> return call_fib4_notifiers(dev_net(nh->fib_nh_dev), >> event_type, &info.info); >> + break; >> default: >> break; >> } >> diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c >> index 31c6c6d99d5e..eb560eecee08 100644 >> --- a/net/ipv4/ip_vti.c >> +++ b/net/ipv4/ip_vti.c >> @@ -351,6 +351,7 @@ static int vti4_err(struct sk_buff *skb, u32 info) >> case ICMP_DEST_UNREACH: >> if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED) >> return 0; >> + break; >> case ICMP_REDIRECT: >> break; >> default: >> diff --git a/net/ipv4/ipcomp.c b/net/ipv4/ipcomp.c >> index b42683212c65..bbb56f5e06dd 100644 >> --- a/net/ipv4/ipcomp.c >> +++ b/net/ipv4/ipcomp.c >> @@ -31,6 +31,7 @@ static int ipcomp4_err(struct sk_buff *skb, u32 info) >> case ICMP_DEST_UNREACH: >> if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED) >> return 0; >> + break; >> case ICMP_REDIRECT: >> break; >> default: >>
diff --git a/net/ipv4/ah4.c b/net/ipv4/ah4.c index 36ed85bf2ad5..fab0958c41be 100644 --- a/net/ipv4/ah4.c +++ b/net/ipv4/ah4.c @@ -450,6 +450,7 @@ static int ah4_err(struct sk_buff *skb, u32 info) case ICMP_DEST_UNREACH: if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED) return 0; + break; case ICMP_REDIRECT: break; default: diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c index 4b834bbf95e0..6cb3ecad04b8 100644 --- a/net/ipv4/esp4.c +++ b/net/ipv4/esp4.c @@ -982,6 +982,7 @@ static int esp4_err(struct sk_buff *skb, u32 info) case ICMP_DEST_UNREACH: if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED) return 0; + break; case ICMP_REDIRECT: break; default: diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index a632b66bc13a..4c0c33e4710d 100644 --- a/net/ipv4/fib_semantics.c +++ b/net/ipv4/fib_semantics.c @@ -1874,6 +1874,7 @@ static int call_fib_nh_notifiers(struct fib_nh *nh, (nh->fib_nh_flags & RTNH_F_DEAD)) return call_fib4_notifiers(dev_net(nh->fib_nh_dev), event_type, &info.info); + break; default: break; } diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c index 31c6c6d99d5e..eb560eecee08 100644 --- a/net/ipv4/ip_vti.c +++ b/net/ipv4/ip_vti.c @@ -351,6 +351,7 @@ static int vti4_err(struct sk_buff *skb, u32 info) case ICMP_DEST_UNREACH: if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED) return 0; + break; case ICMP_REDIRECT: break; default: diff --git a/net/ipv4/ipcomp.c b/net/ipv4/ipcomp.c index b42683212c65..bbb56f5e06dd 100644 --- a/net/ipv4/ipcomp.c +++ b/net/ipv4/ipcomp.c @@ -31,6 +31,7 @@ static int ipcomp4_err(struct sk_buff *skb, u32 info) case ICMP_DEST_UNREACH: if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED) return 0; + break; case ICMP_REDIRECT: break; default:
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- net/ipv4/ah4.c | 1 + net/ipv4/esp4.c | 1 + net/ipv4/fib_semantics.c | 1 + net/ipv4/ip_vti.c | 1 + net/ipv4/ipcomp.c | 1 + 5 files changed, 5 insertions(+)