| Message ID | 20210305094429.GA140795@embeddedor (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [RESEND,next] net/packet: Fix fall-through warnings for Clang | expand |
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:44, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > net/packet/af_packet.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c > index e24b2841c643..880a1ab9a305 100644 > --- a/net/packet/af_packet.c > +++ b/net/packet/af_packet.c > @@ -1652,6 +1652,7 @@ static int fanout_add(struct sock *sk, struct fanout_args *args) > case PACKET_FANOUT_ROLLOVER: > if (type_flags & PACKET_FANOUT_FLAG_ROLLOVER) > return -EINVAL; > + break; > case PACKET_FANOUT_HASH: > case PACKET_FANOUT_LB: > case PACKET_FANOUT_CPU: >
Hi all, If you don't mind, I'm taking this in my -next[1] branch for v5.14. Thanks -- Gustavo [1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp On 4/20/21 15:10, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? > > Thanks > -- > Gustavo > > On 3/5/21 03:44, Gustavo A. R. Silva wrote: >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning >> by explicitly adding a break statement instead of letting the code fall >> through to the next case. >> >> Link: https://github.com/KSPP/linux/issues/115 >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >> --- >> net/packet/af_packet.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c >> index e24b2841c643..880a1ab9a305 100644 >> --- a/net/packet/af_packet.c >> +++ b/net/packet/af_packet.c >> @@ -1652,6 +1652,7 @@ static int fanout_add(struct sock *sk, struct fanout_args *args) >> case PACKET_FANOUT_ROLLOVER: >> if (type_flags & PACKET_FANOUT_FLAG_ROLLOVER) >> return -EINVAL; >> + break; >> case PACKET_FANOUT_HASH: >> case PACKET_FANOUT_LB: >> case PACKET_FANOUT_CPU: >>
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index e24b2841c643..880a1ab9a305 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -1652,6 +1652,7 @@ static int fanout_add(struct sock *sk, struct fanout_args *args) case PACKET_FANOUT_ROLLOVER: if (type_flags & PACKET_FANOUT_FLAG_ROLLOVER) return -EINVAL; + break; case PACKET_FANOUT_HASH: case PACKET_FANOUT_LB: case PACKET_FANOUT_CPU:
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- net/packet/af_packet.c | 1 + 1 file changed, 1 insertion(+)