| Message ID | 20210305170212.146135-1-efremov@linux.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 155b23e6e53475ca3b8c2a946299b4d4dd6a5a1e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | sun/niu: fix wrong RXMAC_BC_FRM_CNT_COUNT count | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 6 maintainers not CCed: vaibhavgupta40@gmail.com leon@kernel.org keescook@chromium.org gustavoars@kernel.org jgg@ziepe.ca kvalo@codeaurora.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 5 Mar 2021 20:02:12 +0300 you wrote: > RXMAC_BC_FRM_CNT_COUNT added to mp->rx_bcasts twice in a row > in niu_xmac_interrupt(). Remove the second addition. > > Signed-off-by: Denis Efremov <efremov@linux.com> > --- > I don't know the code of the dirver, but this looks like a real bug. > Otherwise, it's more readable as: > mp->rx_bcasts += RXMAC_BC_FRM_CNT_COUNT * 2; > > [...] Here is the summary with links: - sun/niu: fix wrong RXMAC_BC_FRM_CNT_COUNT count https://git.kernel.org/netdev/net/c/155b23e6e534 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c index 68695d4afacd..707ccdd03b19 100644 --- a/drivers/net/ethernet/sun/niu.c +++ b/drivers/net/ethernet/sun/niu.c @@ -3931,8 +3931,6 @@ static void niu_xmac_interrupt(struct niu *np) mp->rx_mcasts += RXMAC_MC_FRM_CNT_COUNT; if (val & XRXMAC_STATUS_RXBCAST_CNT_EXP) mp->rx_bcasts += RXMAC_BC_FRM_CNT_COUNT; - if (val & XRXMAC_STATUS_RXBCAST_CNT_EXP) - mp->rx_bcasts += RXMAC_BC_FRM_CNT_COUNT; if (val & XRXMAC_STATUS_RXHIST1_CNT_EXP) mp->rx_hist_cnt1 += RXMAC_HIST_CNT1_COUNT; if (val & XRXMAC_STATUS_RXHIST2_CNT_EXP)
RXMAC_BC_FRM_CNT_COUNT added to mp->rx_bcasts twice in a row in niu_xmac_interrupt(). Remove the second addition. Signed-off-by: Denis Efremov <efremov@linux.com> --- I don't know the code of the dirver, but this looks like a real bug. Otherwise, it's more readable as: mp->rx_bcasts += RXMAC_BC_FRM_CNT_COUNT * 2; drivers/net/ethernet/sun/niu.c | 2 -- 1 file changed, 2 deletions(-)