| Message ID | 20210309044322.3487636-1-andrii@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] selftests/bpf: fix compiler warning in BPF_KPROBE definition in loop6.c | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | fail | 1 blamed authors not CCed: yhs@fb.com; 8 maintainers not CCed: linux-kselftest@vger.kernel.org yhs@fb.com kpsingh@kernel.org kafai@fb.com ast@kernel.org john.fastabend@gmail.com songliubraving@fb.com shuah@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On 3/8/21 8:43 PM, Andrii Nakryiko wrote: > Add missing return type to BPF_KPROBE definition. Without it, compiler > generates the following warning: > > progs/loop6.c:68:12: warning: type specifier missing, defaults to 'int' [-Wimplicit-int] > BPF_KPROBE(trace_virtqueue_add_sgs, void *unused, struct scatterlist **sgs, > ^ > 1 warning generated. > > Fixes: 86a35af628e5 ("selftests/bpf: Add a verifier scale test with unknown bounded loop") > Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Oh, my bad. Thanks for fixing it! Acked-by: Yonghong Song <yhs@fb.com>
diff --git a/tools/testing/selftests/bpf/progs/loop6.c b/tools/testing/selftests/bpf/progs/loop6.c index 2a7141ac1656..38de0331e6b4 100644 --- a/tools/testing/selftests/bpf/progs/loop6.c +++ b/tools/testing/selftests/bpf/progs/loop6.c @@ -65,8 +65,8 @@ int config = 0; int result = 0; SEC("kprobe/virtqueue_add_sgs") -BPF_KPROBE(trace_virtqueue_add_sgs, void *unused, struct scatterlist **sgs, - unsigned int out_sgs, unsigned int in_sgs) +int BPF_KPROBE(trace_virtqueue_add_sgs, void *unused, struct scatterlist **sgs, + unsigned int out_sgs, unsigned int in_sgs) { struct scatterlist *sgp = NULL; __u64 length1 = 0, length2 = 0;
Add missing return type to BPF_KPROBE definition. Without it, compiler generates the following warning: progs/loop6.c:68:12: warning: type specifier missing, defaults to 'int' [-Wimplicit-int] BPF_KPROBE(trace_virtqueue_add_sgs, void *unused, struct scatterlist **sgs, ^ 1 warning generated. Fixes: 86a35af628e5 ("selftests/bpf: Add a verifier scale test with unknown bounded loop") Signed-off-by: Andrii Nakryiko <andrii@kernel.org> --- tools/testing/selftests/bpf/progs/loop6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)