From patchwork Tue Mar 16 13:38:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 12142221 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FA23C433E0 for ; Tue, 16 Mar 2021 13:39:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0B9F65067 for ; Tue, 16 Mar 2021 13:39:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231701AbhCPNjU (ORCPT ); Tue, 16 Mar 2021 09:39:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234629AbhCPNjA (ORCPT ); Tue, 16 Mar 2021 09:39:00 -0400 Received: from michel.telenet-ops.be (michel.telenet-ops.be [IPv6:2a02:1800:110:4::f00:18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE6FEC061756 for ; Tue, 16 Mar 2021 06:38:59 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed20:b1e0:9434:c5b6:aecd]) by michel.telenet-ops.be with bizsmtp id h1ev240010UTkXy061evaT; Tue, 16 Mar 2021 14:38:58 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lM9uQ-0088Qn-IC; Tue, 16 Mar 2021 14:38:54 +0100 Received: from geert by rox.of.borg with local (Exim 4.93) (envelope-from ) id 1lM9uQ-009yLG-6c; Tue, 16 Mar 2021 14:38:54 +0100 From: Geert Uytterhoeven To: "David S . Miller" , Jakub Kicinski , Florian Fainelli , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] net: broadcom: BCM4908_ENET should not default to y, unconditionally Date: Tue, 16 Mar 2021 14:38:53 +0100 Message-Id: <20210316133853.2376863-1-geert+renesas@glider.be> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Merely enabling CONFIG_COMPILE_TEST should not enable additional code. To fix this, drop the automatic enabling of BCM4908_ENET. Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller driver") Signed-off-by: Geert Uytterhoeven --- Feel free to change to "default y if ARCH_BCM4908" and To fix this, restrict the automatic enabling of BCM4908_ENET to ARCH_BCM4908. if you think BCM4908 SoCs cannot be used without enabling this. --- drivers/net/ethernet/broadcom/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig index f8a168b73307c03b..57bac60ba2b190d2 100644 --- a/drivers/net/ethernet/broadcom/Kconfig +++ b/drivers/net/ethernet/broadcom/Kconfig @@ -54,7 +54,6 @@ config B44_PCI config BCM4908_ENET tristate "Broadcom BCM4908 internal mac support" depends on ARCH_BCM4908 || COMPILE_TEST - default y help This driver supports Ethernet controller integrated into Broadcom BCM4908 family SoCs.