| Message ID | 20210316140341.2399108-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a3bc483216650a7232559bf0a1debfbabff3e12c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: masahiroy@kernel.org rdunlap@infradead.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On 3/16/2021 7:03 AM, Geert Uytterhoeven wrote: > Merely enabling compile-testing should not enable additional code. > To fix this, restrict the automatic enabling of BCM4908_ENET to > ARCH_BCM4908. > > Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller driver") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
On 2021-03-16 15:03, Geert Uytterhoeven wrote: > Merely enabling compile-testing should not enable additional code. > To fix this, restrict the automatic enabling of BCM4908_ENET to > ARCH_BCM4908. > > Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 > controller driver") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Rafał Miłecki <rafal@milecki.pl>
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 16 Mar 2021 15:03:41 +0100 you wrote: > Merely enabling compile-testing should not enable additional code. > To fix this, restrict the automatic enabling of BCM4908_ENET to > ARCH_BCM4908. > > Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller driver") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > [...] Here is the summary with links: - [v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally https://git.kernel.org/netdev/net/c/a3bc48321665 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig index f8a168b73307c03b..cb88ffb8f12fa7ef 100644 --- a/drivers/net/ethernet/broadcom/Kconfig +++ b/drivers/net/ethernet/broadcom/Kconfig @@ -54,7 +54,7 @@ config B44_PCI config BCM4908_ENET tristate "Broadcom BCM4908 internal mac support" depends on ARCH_BCM4908 || COMPILE_TEST - default y + default y if ARCH_BCM4908 help This driver supports Ethernet controller integrated into Broadcom BCM4908 family SoCs.
Merely enabling compile-testing should not enable additional code. To fix this, restrict the automatic enabling of BCM4908_ENET to ARCH_BCM4908. Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller driver") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- v2: - Enable by default if ARCH_BCM4908. --- drivers/net/ethernet/broadcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)