| Message ID | 20210317115857.6536-1-memxor@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 58bfd95b554f1a23d01228672f86bb489bdbf4ba |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next,v2] libbpf: use SOCK_CLOEXEC when opening the netlink socket | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | fail | 1 blamed authors not CCed: eric@regit.org; 1 maintainers not CCed: eric@regit.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Kumar Kartikeya Dwivedi <memxor@gmail.com> writes: > Otherwise, there exists a small window between the opening and closing > of the socket fd where it may leak into processes launched by some other > thread. > > Fixes: 949abbe88436 ("libbpf: add function to setup XDP") > Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com> Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Wed, 17 Mar 2021 17:28:58 +0530 you wrote: > Otherwise, there exists a small window between the opening and closing > of the socket fd where it may leak into processes launched by some other > thread. > > Fixes: 949abbe88436 ("libbpf: add function to setup XDP") > Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com> > > [...] Here is the summary with links: - [bpf-next,v2] libbpf: use SOCK_CLOEXEC when opening the netlink socket https://git.kernel.org/bpf/bpf/c/58bfd95b554f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/tools/lib/bpf/netlink.c b/tools/lib/bpf/netlink.c index 4dd73de00..d2cb28e9e 100644 --- a/tools/lib/bpf/netlink.c +++ b/tools/lib/bpf/netlink.c @@ -40,7 +40,7 @@ static int libbpf_netlink_open(__u32 *nl_pid) memset(&sa, 0, sizeof(sa)); sa.nl_family = AF_NETLINK; - sock = socket(AF_NETLINK, SOCK_RAW, NETLINK_ROUTE); + sock = socket(AF_NETLINK, SOCK_RAW | SOCK_CLOEXEC, NETLINK_ROUTE); if (sock < 0) return -errno;
Otherwise, there exists a small window between the opening and closing of the socket fd where it may leak into processes launched by some other thread. Fixes: 949abbe88436 ("libbpf: add function to setup XDP") Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com> --- Changelog: v1 -> v2 Tag the bpf-next tree (Toke) Add a Fixes: tag (Toke) --- tools/lib/bpf/netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)